[ http://issues.apache.org/jira/browse/VELOCITY-403?page=comments#action_12331038 ]
Nathan Bubna commented on VELOCITY-403: --------------------------------------- while patching the dev guide i noticed the following in the Configuration Keys and Values section: runtime.log.error.stacktrace = false runtime.log.warn.stacktrace = false runtime.log.info.stacktrace = false Turns on stacktracing for the three error categories. These produce a large amount of log output. sure enough, there are constants to match these properties in the RuntimeConstants interface, but these are largely unused. the error and info constants are referenced only in the TemplateTestSuite, and the warn constant is curiously used to trigger the showStackTraces junk that i blindly retained/mimicked in my patch (moving it from RuntimeInstance to LogManager and Log). i say we axe these from the documentation, deprecate them in RuntimeConstants, and if anyone is still interested in the showStackTraces stuff, create and use a single property for that rather than weirdly use the RUNTIME_LOG_WARN_STACKTRACE constant to govern all of it. > Enhance Velocity's LogSystem and internal use thereof > ----------------------------------------------------- > > Key: VELOCITY-403 > URL: http://issues.apache.org/jira/browse/VELOCITY-403 > Project: Velocity > Type: Improvement > Components: Source > Reporter: Nathan Bubna > Assignee: Will Glass-Husain > Fix For: 1.5 > Attachments: docs.logging.patch, logging.patch, second.logging.patch > > After several very, very long debates with Geir over commons-logging, i have > become largely convinced that it is something we should do with hesitation > (i.e. let's talk about it for 2.0, but not before). i've also begun to have > some frustrations with commons-logging in both work projects and in > VelocityTools. > regardless of these issues, it is clear to me that Velocity's LogSystem and > use of it is in great need of improvement. we need to lower the priority of > many messages, eliminate some, and above all, upgrade the system itself to be > more useful. > some specific, unevaluated, off-the-cuff ideas are: > -make logging a null-op if no logger is found, rather than panic and break > -detect jdk 1.4+ logging > -add a trace level > -add is<Level>Enabled > -make it possible to grab a LogSystem instance of sorts, so Velocity > extensions can use it more sensibly (i'm tired of the hacks we must do in > Tools) > those are just a few ideas, and they might not all even be feasible. still, > i'm hoping to take a whack at some of this and hoping that others can help me > out. my volunteer time is still rather limited. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
