[ http://issues.apache.org/jira/browse/VELOCITY-403?page=comments#action_12331417 ]
Nathan Bubna commented on VELOCITY-403: --------------------------------------- well, no one but Will has spoken about the weird, half-finished showStrackTraces behavior, and i've been thinking about it a bit more today. and now i think it should completely go away. :) seriously, it only ever partly worked; it doesn't appear to have been used much internally (i.e. few, if any, rsvc.info/warn/error(Throwable) calls); and it's no longer really necessary with the advent of the info/warn/error(String,Throwable) methods in the new Log class. now the user can control stacktrace output via choice of LogChute implementation and/or configuration of its end target. i say we remove all three properties from the default velocity.properties, deprecate the constants in RuntimeConstants, remove support for showStackTraces from Log and LogManager, and update the TemplateTestSuite to no longer use these useless settings. oh, and of course, remove these wholly from the documentation. :) i'll give this a few days for protests/comments, then i'll commit the change, which by the way, should be totally backwards compatible in that nothing will break and even users' log output won't change much, if it all. > Enhance Velocity's LogSystem and internal use thereof > ----------------------------------------------------- > > Key: VELOCITY-403 > URL: http://issues.apache.org/jira/browse/VELOCITY-403 > Project: Velocity > Type: Improvement > Components: Source > Reporter: Nathan Bubna > Assignee: Will Glass-Husain > Fix For: 1.5 > Attachments: docs.logging.patch, logging.patch, second.logging.patch > > After several very, very long debates with Geir over commons-logging, i have > become largely convinced that it is something we should do with hesitation > (i.e. let's talk about it for 2.0, but not before). i've also begun to have > some frustrations with commons-logging in both work projects and in > VelocityTools. > regardless of these issues, it is clear to me that Velocity's LogSystem and > use of it is in great need of improvement. we need to lower the priority of > many messages, eliminate some, and above all, upgrade the system itself to be > more useful. > some specific, unevaluated, off-the-cuff ideas are: > -make logging a null-op if no logger is found, rather than panic and break > -detect jdk 1.4+ logging > -add a trace level > -add is<Level>Enabled > -make it possible to grab a LogSystem instance of sorts, so Velocity > extensions can use it more sensibly (i'm tired of the hacks we must do in > Tools) > those are just a few ideas, and they might not all even be feasible. still, > i'm hoping to take a whack at some of this and hoping that others can help me > out. my volunteer time is still rather limited. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
