Alexey Panchenko <[EMAIL PROTECTED]> writes: >Will Glass-Husain wrote:
>> It's also a big plus if you are active on the user list helping >> people out. >Is it the mandatory requirement ? No. If you want to contribute to Velocity (or to any other Apache project), you should understand, that Apache works in the way of a meritocracy, see http://www.apache.org/foundation/how-it-works.html#meritocracy Joining the user list and helping users out is a way to show the community that you are interested in a long-term contribution to Velocity and know your way around. Which builds merit... ...you get the picture. :-) Velocity is a special case here, because all of us are very reluctant to apply patches "just so". If a patch sits in the Tracker for a long time, chances are that there is a reason why it wasn't applied and the original author wasn't interested to amend the original contribution. A week is not a long time, BTW. Here is, what IMHO helps you to convince a committer to apply your patch (at least that's what works for me): - Describe the issue. Give a test case where a problem is and how your patch changes the problem - Give unit tests - Make sure that your patch adheres to the Velocity coding guidelines (which are basically non-existent but we do have some at http://wiki.apache.org/jakarta-velocity/CodeStandards - Give unit tests - Show that your patch doesn't only "scratch your need" but helps everyone. Understand, that the current committers are very reluctant to apply patches to Velocity because we care a lot about backwards compatibility. - Make sure that all existing Unit test still pass with your patch applied. - And last, but not least, give unit tests. Best is a test that fails before you applied the patch and passes afterwards. Best regards Henning -- Dipl.-Inf. (Univ.) Henning P. Schmiedehausen INTERMETA GmbH [EMAIL PROTECTED] +49 9131 50 654 0 http://www.intermeta.de/ RedHat Certified Engineer -- Jakarta Turbine Development -- hero for hire Linux, Java, perl, Solaris -- Consulting, Training, Development Social behaviour: Bavarians can be extremely egalitarian and folksy. -- http://en.wikipedia.org/wiki/Bavaria Most Franconians do not like to be called Bavarians. -- http://en.wikipedia.org/wiki/Franconia --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
