On Fri, 23 Jun 2006, James Graham wrote:
David Douard wrote:
Nice.
On my side, I've spent some time to do a simiar job (in the train in
which I spend 2 hours a day), but with the SVN version of numpy. I've
done the job the quick'n dirty way (no deep testing, and so), but I plan
to do a cleaner refactoring allowing to choose at install time which
numeric module is used (the way matplotlib does) by Veusz.
I was also wondering if that was worthwhile. If it is, there is the question
of which array interface to use in the wrapper (i.e. NumPy-like or
Numarray-like). I would favour NumPy-like but it does have the significant
disadvantage that documentation is less readily available. My only worry is
that it will produce a significant extra maintainability burden over time.
Thanks James and David. I'm wondering whether it is worth trying to write
a wrapper, seeing as numarray is recommended against, and everyone says
that everything should move over to the new code ASAP. Of course this may
happen again...
I suppose if there's a speed penalty for the wrapper, it wouldn't be so
great. Also maintaining both is a bit of a pain. I'm tempted to just ditch
numarray once PyFITS is working properly with NumPy...
Any opinions?
The other thing I did, which I have forgot to mention is changed all the
setting objects so that all the convertTo methods actually do a
conversion to the relevant python type and raise ValueError if the
conversion fails for whatever reason. I also changed the tests to match
this. I don't know if there's a reason that this change is a bad idea.
Jeremy?
Hmmmm... I liked having some hard checking in there so that you gave
errors rather than allowing people to use strings for integer values and
regretting it later when things break. I'm not a great fan of "sloppy"
type checking.
Do you want me to send the patches I produce ?
Yes :)
Of course! (if you can forgive my irregular replies...)
Jeremy
--
Jeremy Sanders <[EMAIL PROTECTED]>
http://www.jeremysanders.net/ Cambridge, UK
Public Key Server PGP Key ID: E1AAE053
_______________________________________________
Veusz-discuss mailing list
[email protected]
https://mail.gna.org/listinfo/veusz-discuss
