On Sat, 6 Oct 2007 10:22:53 +0200, "Yakov Lerner" <[EMAIL PROTECTED]>
wrote:
> On 10/5/07, Matthew Winn <[EMAIL PROTECTED]> wrote:
> >
> > I've been working on an implementation of the non-uniform tabstops
> > that were discussed about a month ago, and I have a patch ready for
> > trying out. I've done some testing on Linux and Windows XP; the parts
> > I'm able to test seem to be OK and on Linux it survives "make test"
> > cleanly, but I need people to try it out on other systems and test
> > the parts I can't reach.
> >
> > With this patch the set tabstop, set softtabstop and retab commands
> > take a comma-separated list of tab widths (as in ":set ts=4,20,8" or
> > ":retab 20,4").
>
> You changed the option type from numeric to string, right ?
>
> I believe this breaks some backward-compatibility:
> 1) The old code rightly expected &ts to be proper number and did
> arithmetics on it; this gets broken.
> 2) Also, if old code had things like 'set ts+=3', 'set ts-=3', it gets
> broken, too.
Does anyone actually do that? It doesn't make sense to me that anyone
would do arithmetic on a tabstop. I agree that if anyone does it then
it should behave as before. It just doesn't make sense as something
anyone would do. Still, it makes even less sense now:
:set ts=5,7 ts+=3 ts?
tabstop=5,73
Not a very useful ability.
> For preserving backward compatibility, I believe it's better
> to introduce new option name (some 'vst' for variable tabstop, or suchlike)
> than to change the type of existing option.
I did think about adding another two options (two, because there's sts
as well), but then there's a risk of the sort of problem that already
exists with wrapmargin / textwidth, where if the user isn't aware that
one option is set the other seems to be broken because changes to it
are ignored.
It shouldn't be hard to change, though. I'm also wondering if this is
a big enough change to be worth #ifdef FEAT_??? directives.
--
Matthew Winn
--~--~---------~--~----~------------~-------~--~----~
You received this message from the "vim_dev" maillist.
For more information, visit http://www.vim.org/maillist.php
-~----------~----~----~----~------~----~------~--~---
