On 11 July 2010 16:45, Bram Moolenaar wrote: > > Jjgod Jiang wrote (a long time ago): > >> Running vim under Mac OS X terminal do not support copy to/from >> system clipboard currently, this patch add this feature. To have >> this feature in mainstream, we receive the following benifits: >> >> 1. We can copy from/to system clipboard without running GUI. >> (Default vim builds shipped with Mac OS X do not have GUI >> enabled, so it can share this feature.) >> 2. We don't need to duplicate code in GUI implementations like >> MacVim or vim-cocoa. >> >> The clipboard handling code is derived from MacVim. >> >> To use Cocoa APIs, we need to convert os_macosx.c into an Obj-C >> file. Other changes are trivial. > > A few remarks were made after this patch was submitted, but I don't > think I ever saw an updated patch. Is it still coming?
I made the remark that it would be "nicer" to use the C-API (Core Foundation) to implement Copy/Paste instead of converting os_macosx.c to an Objective-C file and then using the MacVim Copy/Paste code which uses the Objective-C API (Foundation). It would not be very difficult to write such a patch but I don't think anybody ever volunteered to do it. The advantages of rewriting the patch are mostly aesthetic -- the functionality would be identical. If you Bram can live with that then I think it is safe to merge this patch (here is one of the problems though: since the patch renames a whole file it is a bit tricky to review -- I believe it is fine but have not checked it myself). If you would prefer not to use Objective-C then it is possible to rewrite it using only C. What would you prefer Bram? Björn -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php
