On Nov 7, 2013 12:27 PM, "Christian Brabandt" <cbli...@256bit.org> wrote: > > On Thu, November 7, 2013 03:26, Bram Moolenaar wrote: > > Thanks. Are you scared of the number 100? :-) > > kind of. The more tests we add, the harder it is to find one, that can > be used for adding more tests. So I figured, it would make sense, to > give them more meaningful names, so one can make an educated guess > from the name what they are about. > > Plus, it prevents name clashes and allows to easier handle local > patches. I have a bunch of local patches laying around, that each > wants to add test100.in and .ok and once I go through my patch queue, > it gets more and more likely, that a patch can't be applied, because > of that.
I have raised the question earlier. I personally have patches with tests 100 (and no 101 and 102), 101 (and no ...), 102 (...). I would suggest giving patches meaningful names, splitting lines in Makefiles into one line per file fashion and telling contributors that they should place tests there in alphabetical order. Splitting and ordering are there to reduce probability of conflicts when merging. > BTW: is there a reason, not to make the Test Makefile use wildcard > expansion to find all relevant tests? (i.e. something like this: > > SCRIPTS = $(subst in,out,$(wildcard test*.in)) > > Well, I just see, this would need a couple of more changes, to exclude > the test*a.in files, but should be reasonable, I think. > (Not sure if this is really workable on non GNU Systems). Some Makefiles do not list all tests because some tests should not be run on some systems. I do not know why usual workaround (copying *.ok to test.out) is not used in such cases though. > > regards, > Christian > > -- > -- > You received this message from the "vim_dev" maillist. > Do not top-post! Type your reply below the text you are replying to. > For more information, visit http://www.vim.org/maillist.php > > --- > You received this message because you are subscribed to the Google Groups "vim_dev" group. > To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/groups/opt_out. -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
