On Thursday, March 27, 2014 1:05:08 PM UTC-4, Ben Fritz wrote: > On Friday, January 31, 2014 1:54:30 PM UTC-6, Daniel "paradigm" Thau wrote: > > On Thursday, January 30, 2014 9:07:19 PM UTC-5, Daniel "paradigm" Thau > > wrote: > > > On Thursday, January 30, 2014 8:07:04 PM UTC-5, Marcin Szamotulski wrote: > > > > On 16:45 Wed 29 Jan , Daniel "paradigm" Thau wrote: > > > > > > > > > Apologies for the delay. > > > > > > > > > > > > > > > > > > Review for those who have forgotten and/or don't care to backread: > > > > > > > > > > > > > > > > > > This patch adds a new text object, "m", which will take one more > > > > > character as input. That character will be used as bounds to the > > > > > left and right for the object. For example, "cim$" will change > > > > > between dollar signs. This supports multi-line objects, so one could > > > > > do "cim'" which, unlike "ci'", will search across lines; this way > > > > > users have both. > > > > > > > > > > > > > Thanks I'm really happy to see this patch. I compiled it now and there > > > > > > > > is one thing that does not work: the "." command. For example di< or > > > > ci< > > > > > > > > can be repeated with . but dim, or cim, cannot. > > > > > > > > > > > > > > > > Best regards, > > > > > > > > Marcin Szamotulski > > > > > > Good catch. I can replicate that on my end. Will fix. > > > > Should be fixed in the attachment. As a bonus, it now supports things such > > as digraphs. > > I tried updating this patch for 7-4-220 and mostly succeeded, just by > applying a couple hundred lines of fuzz, but visual mode is not selecting the > full text inside the matched pairs. I don't have time to try to fix it > further. I'm attaching the updated patch in case I just did something wrong. > I know there have been some visual mode changes outside of this patch between > now and the time the patch was created.
Thanks for staying on this! My schedule has hit a huge crunch for the next month or two, and I don't want to rush a fix out myself and risk causing new issues. I'd rather delay fixing this and ensure that when I do the patch is as clean and bug-free as is possible against the code base at that time. When my schedule clears I may also add functionality for adding a v:count to the text object calls, which currently does not work for the new functionality for either of my patches. I might change how my tests work as well in order to have them both be cleaner and more thorough. -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
