Hirohito Higashi wrote:
> To: Bram (As a Vimboss)
> To: Christian Brabandt (As a visual <C-A>/<C-X> first patch author)
> To: Jason Schulz (As a support for bin 'nrformats' patch author)
>
> Hi,
>
> I refactored visual <C-A>/<C-X> to support vcol et al.
> This mean is <TAB> code free!
>
> Contents of patch.
> - visual <C-A>/<C-X> support vcol. (<TAB> code free)
> - 'test_increment' convert from old style test to new style test. and added
> some test items.
> - Processing was allowed to separate.
> (line loop process and add/subtract process)
> (We have to use the existing function block_prep() to process the
> block-wise)
> - We removed the halfway right-to-left processing.
> (Remove RLADDSUBFIX() macro)
> (This is causing the actual problem)
> $ vim -Nu NONE -c "set rightleft"
> i123 45<Esc>
> <C-A> " Unexpected swap the numbers of strings occurred.
>
> Christian Brabandt and Jason Schulz and List>
> I was wondering if you could review this patch.
>
> Jason Schulz>
> Sorry to such just your patch was included.
> I have just completed the doing has been working since last fall :-)
That's a big change. Can you give an example of what didn't work before
and works now?
To make reviewing easier, it would be good to first make a patch to
change the test from old to new style. Then we know the test works with
the old code.
Then change the code and extend the test with parts that didn't
work before. So we can clearly see what's fixed. And then if one would
try to only include the change to the tests would require the test to
fail.
The docs are not updated, thus for the user there is no change?
--
Biting someone with your natural teeth is "simple assault," while biting
someone with your false teeth is "aggravated assault."
[real standing law in Louisana, United States of America]
/// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
