Hirohito Higashi wrote:
> > > To: Bram (As a Vimboss)
> > > To: Christian Brabandt (As a visual <C-A>/<C-X> first patch author)
> > > To: Jason Schulz (As a support for bin 'nrformats' patch author)
> > >
> > > Hi,
> > >
> > > I refactored visual <C-A>/<C-X> to support vcol et al.
> > > This mean is <TAB> code free!
> > >
> > > Contents of patch.
> > > - visual <C-A>/<C-X> support vcol. (<TAB> code free)
> > > - 'test_increment' convert from old style test to new style test. and
> > > added some test items.
> > > - Processing was allowed to separate.
> > > (line loop process and add/subtract process)
> > > (We have to use the existing function block_prep() to process the
> > > block-wise)
> > > - We removed the halfway right-to-left processing.
> > > (Remove RLADDSUBFIX() macro)
> > > (This is causing the actual problem)
> > > $ vim -Nu NONE -c "set rightleft"
> > > i123 45<Esc>
> > > <C-A> " Unexpected swap the numbers of strings occurred.
> > >
> > > Christian Brabandt and Jason Schulz and List>
> > > I was wondering if you could review this patch.
> > >
> > > Jason Schulz>
> > > Sorry to such just your patch was included.
> > > I have just completed the doing has been working since last fall :-)
> >
> > That's a big change. Can you give an example of what didn't work before
> > and works now?
>
> Please see Test_visual_increment_27() ~ Test_visual_increment_34().
> Below is ather exsample.
>
> Case 1 (Visual blockwise <C-A> with TAB and SPACE mixed)
> - Manipulate
> $ vim -Nu NONE
> :call setline(1, ["1234 56", "\<TAB>78"])
> :exec "norm! ggw\<C-V>jl\<C-A>"
> - Expect result
> "1234 57"
> "\<TAB>79"
> - Unpatched result
> "1235 56"
> "\<TAB>79"
I see, thanks for fixing that.
> > To make reviewing easier, it would be good to first make a patch to
> > change the test from old to new style. Then we know the test works with
> > the old code.
>
> Okay. I attached simple patch that only convert to new style test of
> test_increment.
Thanks. The original test had a nice explanation of what it was doing.
Although the new style test do have the assert_equal() calls that make
it easier to see what is going on, the commands themselves are still a
bit of a puzzle. Since the explanations were already written, we can
keep them. Using the comment above the test function should work well.
--
A parent can be arrested if his child cannot hold back a burp during a church
service.
[real standing law in Nebraska, United States of America]
/// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
