On 2016/02/04, at 8:11, Bram Moolenaar <b...@moolenaar.net> wrote:

> Patch 7.4.1256
> Problem:    On Mac sys.exit(0) doesn't kill the test server.

I think sys.exit() was not working on Linux also. Anyway, 

[1] test_channel.py in git master dosen't have the execution permission.

[2] the comment
    # Exit the server thread when the main thread terminates
was there to explain what 'server_thread.daemon = True' was doing.
Now the server thread does not terminate when the main thread terminates.

PS
I intentionally commented out one of the following two lines
  call ch_sendexpr(handle, '!quit!', 0)
  call s:kill_server()
and the python server correctly terminated (or was killed) in either case.

Jun Takimoto

diff --git a/src/testdir/test_channel.py b/src/testdir/test_channel.py
old mode 100644
new mode 100755
index fb75938..f1c2ec5
--- a/src/testdir/test_channel.py
+++ b/src/testdir/test_channel.py
@@ -126,8 +126,6 @@ if __name__ == "__main__":
     # Start a thread with the server -- that thread will then start one
     # more thread for each request
     server_thread = threading.Thread(target=server.serve_forever)
-
-    # Exit the server thread when the main thread terminates
     server_thread.start()
 
     # Write the port number in Xportnr, so that the test knows it.



-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to