Jun T wrote:

> On 2016/02/04, at 8:11, Bram Moolenaar <b...@moolenaar.net> wrote:
> 
> > Patch 7.4.1256
> > Problem:    On Mac sys.exit(0) doesn't kill the test server.
> 
> I think sys.exit() was not working on Linux also. Anyway, 

It was working for me.  Might depend on the library version.

> [1] test_channel.py in git master dosen't have the execution permission.

I decided to remove that.  When getting the sources in another way it
won't be executable.  It's easy to just run the python command.

> [2] the comment
>     # Exit the server thread when the main thread terminates
> was there to explain what 'server_thread.daemon = True' was doing.
> Now the server thread does not terminate when the main thread terminates.

Looks like I missed that part.  I'll update the comments a bit more.

> PS
> I intentionally commented out one of the following two lines
>   call ch_sendexpr(handle, '!quit!', 0)
>   call s:kill_server()
> and the python server correctly terminated (or was killed) in either case.

That's good.  Keep an eye out for any other problems.  Asynchronous
stuff is always difficult.  Also, if the test fails it should still take
down the server.  Well, at least in the most common cases, such as an
assert failing.  When Vim crashes all is lost...


-- 
All true wisdom is found on T-shirts.

 /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net   \\\
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\  an exciting new programming language -- http://www.Zimbu.org        ///
 \\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Raspunde prin e-mail lui