Hi, Christian Please try the attached patch.
2016-02-14 6:26 GMT+09:00 Christian Brabandt <[email protected]>: > Hi Kazunobu! > > On Sa, 13 Feb 2016, Kazunobu Kuriyama wrote: > > > Does the new patch fix this issue? > > > > It also contains fixes for known bugs: > > > > > (1) Cursors on unused windows sometimes fails to be cleared. > > > (2) With :split, the scrollbar won't appear. > > > > In addition to those bug fixes, code cleanup was done: the CPP macros > such as > > GTK_DISABLE_DEPRECATED, GDK_DISABLE_DEPRECATED, GSEAL_ENABLE and > > GTK_DISABLE_SINGLE_INCLUDES were all gone and replaced with USE_GTK3 and > > GTK_CHECK_VERSION(), and the dead code which was used only for the > transition > > was eliminated. > > I just wanted to apply. Unfortunately, it did not apply cleanly. First, > patch did not apply cleanly to channel.c in channel_gui_register(). I > guess, this was caused by the recent work on the channels, that is > currently happening. > That's due to the variable name changes of v7.4.1310; the previous gtk3 patch was made against v7.4.1308. To avoid possible confusion, I'll send new gtk3 patches to the list with the new naming convention gtk3-<vim git tag>.patch instead of gtk3-update<serial #>.patch. > After fixing this, I still see > this error: > > gui_gtk_x11.c: In function ‘gui_mch_clear_block’: > gui_gtk_x11.c:6513:14: warning: variable ‘color’ set but not used > [-Wunused-but-set-variable] > GdkColor color; ^ Fixed, although it's not an error. -Wunused-but-set-variable is too clever... Anyway, the neater, the better, I agree on that :) gui_gtk_f.c: In function ‘gtk_form_realize’: > gui_gtk_f.c:387:5: warning: implicit declaration of function > ‘gtk_form_set_static_gravity’ [-Wimplicit-function-declaration] > gtk_form_set_static_gravity(form->bin_window, TRUE); > ^ > gui_gtk_f.c: In function ‘gtk_form_realize_child’: > gui_gtk_f.c:905:43: error: ‘GtkWidget’ has no member named ‘window’ > gtk_form_set_static_gravity(child->widget->window, TRUE); > ^ > Makefile:2770: recipe for target 'objects/gui_gtk_f.o' failed > make: *** [objects/gui_gtk_f.o] Error 1 > make: *** Waiting for unfinished jobs.... > Fixed. gtk_form_set_static gravity() calls gdk_window_set_static_gravities(), which has been deprecated since 3.16.0. I eliminated the calls of gtk_from_set_static_gravity() for 3.16.0 or later, but forgot to leave its implementation for 3.15.0 or earlier. Since I'm using 3.18.7 for the development, it's hard for me with my environment to check if the resulting gui_gtk_f.o will indeed link to the gdk function defined in your GTK library. So, if you still have any problem on that, please let me know. Best regards, Kazunobu > > Best, > Christian > > -- > -- > You received this message from the "vim_dev" maillist. > Do not top-post! Type your reply below the text you are replying to. > For more information, visit http://www.vim.org/maillist.php > > --- > You received this message because you are subscribed to the Google Groups > "vim_dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/d/optout. > -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
gtk3-v7.4.1317.patch.gz
Description: GNU Zip compressed data
