2016-02-15 18:28 GMT+09:00 SungHyun Nam <[email protected]>: > Hello, > > First of all, many thanks for your effort. > I followed your every patch. >
Thank you. That really encourages me. > > And I used 'gtk3-v7.4.1317' this whole day with NO PROBLEM. > To me, it seems gtk3-v7.4.1317 is same as gtk2 version (or maybe > even better (*1*)). > Although I didn't write it explicitly, one of the aims of the development is to port the features of GTK+ 2 vim to GTK+ 3 successfully. Making a resulting GTK+ 3 vim more GTK+ 3-ish is a feature theme. I'd be happy if you would join us for that, too. > > Now, I tested gtk3-v7.4.1320. It seems it almost work fine. > Maybe one regression. If I do ":make", cursor blinks very fast > with this version. With the gtk3-v7.4.1317, cursor does not > blink. > To check if the current approach fixes cursor updates, the current implementation is greedy exploiting the idle time of the main loop. So, please care about the CPU usage/load while testing the current patch. I'll fix it before the summer. No one wants vim to make a big noise with the fan :) > > And there are warning messages in console. > (gvim:30957): Gtk-WARNING **: GtkNotebook 0x1e7f190 is mapped but > visible child GtkEventBox 0x1e80140 is not mapped > When you open tabs, you can select a tab with a mouse click, I think it's OK. Perhaps, those warnings could disappear by updating GTK+. > > Thanks, > namsh > > *1*) Actually I used gtk3-update4 for my daily job. Though it > has cursor draw issue, I remember I don't need any redraw (ctrl-L) > to see the characters. I need redraw with gtk2 version sometimes. > Well, I'm not 100% sure because I think I don't use gtk3 version > not much yet (for various condition). > My GTK+ 3 Vim has been working hard to give its birth, but the guy who has been making the patches are a bit lazy. So, he is asking you for your patience for a while :) By the way, I know there are the blocks of code for the Hangul input in GTK relevant files. I've paid attention for not breaking them, but I cannot say I'm always perfect on that. If you find anything wrong, including GTK+3 patches, please let me know. Best regards, Kazunobu > > 2016-02-15 오후 5:05에 Kazunobu Kuriyama 이(가) 쓴 글: > > Thank you for the comment. > > > > To me, the cursor draw issue is another side of the redraw issue; one > > issue is tried to be fixed, another manifests then :) > > > > To fix those two issues simultaneously and make the code portable, I > > wrote another patch in such a way that no assumption was made on what > > had already been drawn on the cairo surface. It may be inefficient but > > looks surer of redraw. > > > > While the complexity of the draw event function increases, I wish it > > will work on Linux. > > > > Please try it at your convenient time. > > > > The patch was made against v7.4.1320, some merge conflicts resolved. > > > > Best regards, > > Kazunobu Kuriyama > > > > 2016-02-15 15:32 GMT+09:00 Marius Gedminas <[email protected] > > <mailto:[email protected]>>: > > > > On Sun, Feb 14, 2016 at 05:01:22PM +0900, Kazunobu Kuriyama wrote: > > > Hmm... > > > > > > Looks Linux X11 or GTK works differently from that for OS X. > > > > It must be hard trying to fix something when you cannot reproduce a > > problem. Have you tried running Linux in a virtual machine? > > > > > Could you please change a cpp directive from #if 0 to #if 1 at > > > gui_gtk_x11.c:633, although that causes logically unnecessary > redraws? > > > > The screen gets redrawn *mostly* correctly after a PageDown with > > this change. > > > > Here are three screenshots: http://imgur.com/a/NImWI > > 1. after :help > > 2. after <PageDown> > > 3. after <C-L> > > > > > What happens to cursor(s)? Does the GUI clears cursors on unused > windows? > > > > No -- the cursor remains on the inactive window, and also on the > command > > line. > > > > The cursor blinking in the active window is also broken: when I > > switch to > > a window (or move the cursor) the cursor is briefly visible, then it > > blinks out of existence and doesn't reappear until I move the cursor > > again. > > > > My .vimrc has this line: > > > > set guicursor+=a:blinkon0 " disable cursor blinking > > > > ever since my redraw call logging experiments, so the cursor > shouldn't > > be blinking at all. > > > > > > Once, I did :set lines=24 columns=80 and the entire window was solid > > grey > > until I forced a redraw with Ctrl-L. I can no longer reproduce that > > intentionally. > > > > It's as if some kind of double-buffering going on, and gvim is > > *sometimes* drawing into the wrong buffer, due to a race condition or > > something. > > > > On Sun, Feb 14, 2016 at 05:20:57PM +0900, Kazunobu Kuriyama wrote: > > > By the way, how about your resurrected icons? > > > > > > It looks to me that they appear on the toolbar, right? > > > > Yes. > > > > Regards, > > Marius Gedminas > > -- > > One picture is worth 128K words. > > > > -- > > -- > > You received this message from the "vim_dev" maillist. > > Do not top-post! Type your reply below the text you are replying to. > > For more information, visit http://www.vim.org/maillist.php > > > > --- > > You received this message because you are subscribed to the Google > > Groups "vim_dev" group. > > To unsubscribe from this group and stop receiving emails from it, > > send an email to [email protected] > > <mailto:vim_dev%[email protected]>. > > For more options, visit https://groups.google.com/d/optout. > > > > > > -- > > -- > > You received this message from the "vim_dev" maillist. > > Do not top-post! Type your reply below the text you are replying to. > > For more information, visit http://www.vim.org/maillist.php > > > > --- > > You received this message because you are subscribed to the Google > > Groups "vim_dev" group. > > To unsubscribe from this group and stop receiving emails from it, send > > an email to [email protected] > > <mailto:[email protected]>. > > For more options, visit https://groups.google.com/d/optout. > > > -- > -- > You received this message from the "vim_dev" maillist. > Do not top-post! Type your reply below the text you are replying to. > For more information, visit http://www.vim.org/maillist.php > > --- > You received this message because you are subscribed to the Google Groups > "vim_dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/d/optout. > -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
