Yasuhiro Matsumoto wrote:
> On Friday, February 19, 2016 at 6:58:48 AM UTC+9, Bram Moolenaar wrote:
> > I don't quite get it. Looking at the code, this ch_readraw() doesn't
> > specify a callback for the one read, it specifies a new callback for the
> > channel. That's not what the user expects. Better do something like:
> >
> > call ch_setoptions(channel, {"callback": "Callback"})
> >
> > I find it unexpected that ch_readraw() doesn't actually read anything.
> >
> > For ch_sendraw() and ch_sendexpr(), if a callback is specified the
> > functions don't wait for a response and let that specific callback
> > handle the response. When using JS or JSON the sequence number can be
> > used to know which response belongs to which request. With RAW and NL
> > we can only guess that the responses come in the same order as the
> > requests.
> >
> > Queing up callbacks for RAW and NL responses isn't implemented yet,
> > perhaps that confused you.
> >
> > This change seems to also support some other waiting for Win32, it's
> > hard to see from the diff. Perhaps you can adjust the patch for that,
> > or move it to a new patch?
>
> I updated patch.
>
> https://gist.github.com/mattn/d6198b38d9b18edcb2aa
Thanks. However, when I include the part of this change around
channel_wait() then the tests fail. It appears this is because of the
comment:
* Always returns OK for FEAT_GUI_W32.
is no longer true. I tried using select() also for the GUI but that
doesn't work, of course.
So I added an #ifdef to return OK for FEAT_GUI_W32 after checking the
pipes. I hope that works for now. At least the tests pass on my
system.
--
You got to work at a mill? Lucky! I got sent back to work in the
acid-mines for my daily crust of stale bread... which not even the
birds would eat.
/// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
