Yasuhiro Matsumoto wrote:

> On Saturday, February 20, 2016 at 5:02:17 AM UTC+9, Bram Moolenaar wrote:
> > Thanks.  However, when I include the part of this change around
> > channel_wait() then the tests fail.  It appears this is because of the
> > comment:
> >     * Always returns OK for FEAT_GUI_W32.
> > 
> > is no longer true.  I tried using select() also for the GUI but that
> > doesn't work, of course.
> > 
> > So I added an #ifdef to return OK for FEAT_GUI_W32 after checking the
> > pipes.  I hope that works for now.  At least the tests pass on my
> > system.
> 
> Windows can't select file handle. So can't return OK always.

The tests are passing, but always returning OK doesn't look so good.
Also, the "loop" variable in channel_handle_events() looks a bit
strange.

I hope you find some time to further improve this.  I hope to make
stderr work this weekend, perhaps some Win32 changes will be needed for
that as well.

-- 
PRINCE:    He's come to rescue me, father.
LAUNCELOT: (embarrassed) Well, let's not jump to conclusions ...
                 "Monty Python and the Holy Grail" PYTHON (MONTY) PICTURES LTD

 /// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net   \\\
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\  an exciting new programming language -- http://www.Zimbu.org        ///
 \\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Raspunde prin e-mail lui