Hi Yegappan and Bram, 2016-3-23(Wed) 22:52:18 UTC+9 yega...@gmail.com: > Hi, > > On Wed, Mar 23, 2016 at 5:36 AM, h_east <h.east....@gmail.com> wrote: > > > >> > On Mon, Mar 21, 2016 at 2:45 AM, Dominique Pellé > >> > <dominique.pe...@gmail.com> wrote: > >> > > Hi > >> > > > >> > > afl-fuzz found another crash with use of freed memory in vim-7.4.1627 > >> > > (and older) in quickfix code. This is a different bug that the one > >> > > fixed > >> > > recently in Vim-7.4.1592: > >> > > > >> > > >> > The attached patch fixes this issue. These issues are caused by autocmds > >> > modifying the location list while the location list is being used. > >> > >> This issue also occurs with the quickfix. > >> > >> ]$ vim -Nu NONE -S crash_qf.vim > >> Vim: Caught deadly signal SEGV > >> > >> Vim: Finished. > >> Segmentation fault (core dumped) > >> > >> PS > >> I think we should abort even if `qi->qf_curlist` has changed. > >> > >> I'm sorry. In fact, I have had already written a patch. > >> But did not yet been submitted. > >> I'll send patch later. > > > > A patch is attached. > > Please check it. > > > > The patch looks good to me. One comment: When the quickfix/location > list is modified, the opened_window variable is set to FALSE even though > the window is still valid/open. I think, in this case the new window needs > to be closed. The opened_window variable should be set to FALSE > only when win_valid() returns FALSE.
Thanks for the comment. While I'm sleeping, Bram fixed this comment's issue :-) patch 7.4.1640 https://github.com/vim/vim/commit/ffec3c53496d49668669deabc0724ec78e2274fd Thank you Bram! -- Best regards, Hirohito Higashi (a.k.a. h_east) -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
