Hi thinca, 2016-9-30(Fri) 1:39:34 UTC+9 thinca: > :help systemlist() says: > > > > Output is the same as readfile() will output with {binary} argument > > set to "b". > > > > And :help readfile() says: > > > > When {binary} contains "b" binary mode is used: > > > When the last line ends in a NL an extra empty list item is > added. > No CR characters are removed. > > > > > systemlist() doesn't satisfy the first matter. > > > :echo systemlist('echo hello') > " => ['hello'] > " `echo` command outputs text with NL, > " so this should be ['hello', ''] > > > This change fixes the above problem. > > > > You can view, comment on, or merge this pull request online at: > > https://github.com/vim/vim/pull/1135 > > Commit Summary > > Fix systemlist() > > > File Changes > > > M > src/Makefile > (1) > > > M > src/evalfunc.c > (2) > > > A > src/testdir/test_system_func.vim > (20) > > > > Patch Links: > > https://github.com/vim/vim/pull/1135.patch > https://github.com/vim/vim/pull/1135.diff
Good patch👍 Unfortunately, test that your have to add is not running in the Travis CI and AppVeyor. You should modified as follows: diff -ru vim.orig/src/testdir/Make_all.mak vim/src/testdir/Make_all.mak --- vim.orig/src/testdir/Make_all.mak 2016-09-29 11:54:58.000000000 +0900 +++ vim/src/testdir/Make_all.mak 2016-09-30 09:26:47.771610300 +0900 @@ -182,6 +182,7 @@ test_stat.res \ test_substitute.res \ test_syntax.res \ + test_system_func.res \ test_textobjects.res \ test_undo.res \ test_usercommands.res \ If you want to run from test_alot.vim as follows: diff -ru vim.orig/src/testdir/test_alot.vim vim/src/testdir/test_alot.vim --- vim.orig/src/testdir/test_alot.vim 2016-09-29 11:54:58.000000000 +0900 +++ vim/src/testdir/test_alot.vim 2016-09-30 10:00:40.479191900 +0900 @@ -41,6 +41,7 @@ source test_tagjump.vim source test_timers.vim source test_true_false.vim +source test_system_func.vim source test_unlet.vim source test_window_cmd.vim source test_options.vim -- Best regards, Hirohito Higashi (a.k.a. h_east) -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.