Hirohito Higashi wrote:

> 2017-2-5(Sun) 6:40:51 UTC+9 [email protected]:
> > Hi Bram,
> > 
> > The mode(1) function currently returns "ic" after pressing CTRL-X CTRL-L
> > instead of "ix". The attached patch fixes this. I have also updated the
> > test case with some comments.
> 
> Hmm, I can not agree to your patch.
> 
> Please check my comment.
> https://groups.google.com/d/msg/vim_dev/RPdz9YI4kCY/5swDbK2VCgAJ
> > `ins_compl_active()` should be referenced before referring to `ctrl_x_mode`.
> > My patch's 'x' means "wait for CTRL-X mode selection".
> > That is, when the following text is displayed on the last line.
> > -- ^X mode (^]^D^E^F^I^K^L^N^O^Ps^U^V^Y)
> 
> In `ic` and `ix`, the accepted key input is obviously different.
> Perhaps we should change the documentation of `mode()`.
> I think 8.0.0283's mode() behavior is right.

Well, one could argue that this is a third mode.  But only a few keys
are interpreted differently, especially CTRL-N and CTRL-P.  But for most
cases that doesn't matter, thus I agree that "ic" is the best answer.

-- 
Close your shells, or I'll kill -9 you
Tomorrow I'll quota you
Remember the disks'll always be full
And then while I'm away
I'll write ~ everyday
And I'll send-pr all my buggings to you.
    [ CVS log "Beatles style" for FreeBSD ports/INDEX, Satoshi Asami ]

 /// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net   \\\
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\  an exciting new programming language -- http://www.Zimbu.org        ///
 \\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Raspunde prin e-mail lui