Hi Hirohito, On Sat, Feb 4, 2017 at 2:46 PM, h_east <[email protected]> wrote: > Hi Yegappan, > > 2017-2-5(Sun) 6:40:51 UTC+9 [email protected]: >> Hi Bram, >> >> The mode(1) function currently returns "ic" after pressing CTRL-X CTRL-L >> instead of "ix". The attached patch fixes this. I have also updated the >> test case with some comments. > > Hmm, I can not agree to your patch. > > Please check my comment. > https://groups.google.com/d/msg/vim_dev/RPdz9YI4kCY/5swDbK2VCgAJ >> `ins_compl_active()` should be referenced before referring to `ctrl_x_mode`. >> My patch's 'x' means "wait for CTRL-X mode selection". >> That is, when the following text is displayed on the last line. >> -- ^X mode (^]^D^E^F^I^K^L^N^O^Ps^U^V^Y) >
I thought it will be useful to differentiate between using the CTRL-N/CTRL-P keys in the CTRL-X completion mode and in the non CTRL-X completion mode. If it is not going to be helpful, then returning "ic" in both cases is fine. - Yegappan > > In `ic` and `ix`, the accepted key input is obviously different. > Perhaps we should change the documentation of `mode()`. > I think 8.0.0283's mode() behavior is right. > -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
