Hi Kazunobu,
2017-2-5(Sun) 23:50:11 UTC+9 Kazunobu Kuriyama:
> 2017-02-05 23:22 GMT+09:00 h_east <[email protected]>:
>
>
> Hi Kazunobu,
>
>
>
> 2017-2-5(Sun) 23:03:59 UTC+9 Kazunobu Kuriyama:
>
> > Hi,
>
> >
>
> >
>
> > Attached is a tiny, trivial supplement to test_gui. Any comments and/or
> > suggestions are welcome, as you all know, I'm not used to writing new tests
> > for Vim :)
>
>
>
> + call assert_true(1, match(execute('echo getwinposx()'),
> '\(%-1\)\|\(%\d\+\)') >= 0)
>
> + call assert_true(1, match(execute('echo getwinposy()'),
> '\(%-1\)\|\(%\d\+\)') >= 0)
>
> ...
>
> + if s:x11_based_gui
>
> + call assert_true(1, match(execute('echo v:windowid'), '\d\+') >= 0)
>
>
>
> Where the `assert_true()` is used arguments are strange.
>
> The first argument is unnecessary.
>
> Please see the document. (:h assert_true())
>
> Alternatively, use `assert_equal()` with the arguments intact.
>
>
>
> Oh my... Then, in addition to them, you think the existing test:
Oh.. I ran `git blame`.
https://github.com/vim/vim/commit/877e95779869c5426102aa491f67d99904c8534c#diff-b0ecdb9727c1837bc56a4739f58f71ddR27
Humans sometimes make mistakes.
Mistakes should be fixed if found😉
>
>
> > call assert_true(1, match(execute('winpos'), 'Window position: X \d\+, Y
> > \d\+' <<<<) >= 0)
>
>
>
> should also be corrected, right?
Yeah.
>
>
> Along that line, I revised the patch. I'd be happy if you could check it.
I checked. Looks good for me👍
--
Best regards,
Hirohito Higashi (a.k.a. h_east)
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
