> > Hi Kazunobu,
> >
> > 2017-2-5(Sun) 23:03:59 UTC+9 Kazunobu Kuriyama:
> > > Hi,
> > >
> > >
> > > Attached is a tiny, trivial supplement to test_gui. Any comments and/or
> > suggestions are welcome, as you all know, I'm not used to writing new tests
> > for Vim :)
> >
> > + call assert_true(1, match(execute('echo getwinposx()'),
> > '\(%-1\)\|\(%\d\+\)') >= 0)
> > + call assert_true(1, match(execute('echo getwinposy()'),
> > '\(%-1\)\|\(%\d\+\)') >= 0)
> > ...
> > + if s:x11_based_gui
> > + call assert_true(1, match(execute('echo v:windowid'), '\d\+') >= 0)
> >
> > Where the `assert_true()` is used arguments are strange.
> > The first argument is unnecessary.
> > Please see the document. (:h assert_true())
> > Alternatively, use `assert_equal()` with the arguments intact.
> >
>
> Oh my... Then, in addition to them, you think the existing test:
>
> > call assert_true(1, match(execute('winpos'), 'Window position: X \d\+, Y
> \d\+' <<<<) >= 0)
>
> should also be corrected, right?
>
> Along that line, I revised the patch. I'd be happy if you could check it.
Instead of using assert_true() with a match(), using assert_match()
works better, the error message gives a hint about what's wrong.
--
Females are strictly forbidden to appear unshaven in public.
[real standing law in New Mexico, United States of America]
/// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
