Hi Andy, Bram and all, I am author of Patch 7.4.709.
2017-7-20(Thu) 22:36:25 UTC+9 Andy Wokula: > Am 19.07.2017 um 22:22 schrieb Bram Moolenaar: > > > > Andy Wokula wrote: > > > >> Looks like Patch 7.4.709 isn't ok yet, even the test is wrong: > >> > >> " starting at first tab page (see link): > >> tabmove 5 > >> call assert_equal(5, tabpagenr()) > >> > >> should be > >> call assert_equal(6, tabpagenr()) > >> > >> because it's supposed to move the tab page to *after* tab page number 5; > >> > >> when starting at a higher tab page (e.g. 9) it works ok (as it used to be > >> in older Vims), > >> but the test is missing, something like: > >> > >> normal! 9gt > >> tabmove 5 > >> call assert_equal(6, tabpagenr()) > >> > >> https://github.com/vim/vim/blob/master/src/testdir/test_tabpage.vim#L83 > >> (at v8.0.0734) > > > > In my idea it's OK. Say you start with these tab pages: > > > > 1 one > > 2 two > > 3 three > > 4 four > > 5 five > > > > Now you do ":tabmove 3", so it move to after "three". Result: > > > > 1 two > > 2 three > > 3 one > > 4 four > > 5 five > > > > So the current tab is now 3. It moves to after "three", and since all > > the tab pages move left one place you end up at tab page 3. > > To me, that interpretation feels weird. > I think the changed behavior was just an undesired side effect of the patch No, I made this change consciously. The current specification that moves based on the tab number before tab movement. I think it makes sense. Rather, I felt that the previous specification was hard to understand. I definitely think it was bad that I did not mention this specification change clearly... BTW, Did you see the threads discussed? https://groups.google.com/d/topic/vim_dev/swpWq_T_23U/discussion -- Best regards, Hirohito Higashi (h_east) > which just nobody noticed so far. > > It was different before, and more logical IMHO, > because one could use a formula for the target tab page that > didn't depend on the number of the current tab page. > > And: if there are two possible interpretations, we should prefer > the backwards compatible one, right? > (I mean backwards compatible to before 7.4.709) > > -- > Andy -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
