On 2012-05-14, Christian Brabandt wrote: > This patch fixes a data conversion error, that leads to a data loss. > Problem is, that open() is done, even though it is not clear, conversion > will work. So this patch runs buf_write_bytes() twice, first time is to > check that each character can be converted successfully and only if this > does not return, does it really open the file and write the result. > > Problem is, this will probably slow down writing speed, as > buf_write_bytes needs to be called twice. > > I have tested it with the given sample and it works here.
How much slower is it for a file large enough that the write times are more than a second? I don't think we want to noticeably slow down Vim for everyone all the time in order to more-conveniently avoid an error that is observed once in 15 years. Regards, Gary -- You received this message from the "vim_use" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php
