"Michael S. Tsirkin" <m...@redhat.com> writes: >> + if (virtio_has_feature(vdev, VIRTIO_NET_F_MAC)) { >> + /* Set MAC address by writing config space */ >> vdev->config->set(vdev, offsetof(struct virtio_net_config, mac), >> dev->dev_addr, dev->addr_len); >> + } >> > > By the way, why don't we fail the command if VIRTIO_NET_F_MAC is off? > Rusty?
Looked back through the history for this one. I think the theory is that if the guest doesn't set VIRTIO_NET_F_MAC, it means it doesn't care: it's up to the guest. Cheers, Rusty. _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization