Tue, Apr 10, 2018 at 11:26:08PM CEST, step...@networkplumber.org wrote: >On Tue, 10 Apr 2018 11:59:50 -0700 >Sridhar Samudrala <sridhar.samudr...@intel.com> wrote: > >> Use the registration/notification framework supported by the generic >> bypass infrastructure. >> >> Signed-off-by: Sridhar Samudrala <sridhar.samudr...@intel.com> >> --- > >Thanks for doing this. Your current version has couple show stopper >issues. > >First, the slave device is instantly taking over the slave. >This doesn't allow udev/systemd to do its device rename of the slave >device. Netvsc uses a delayed work to workaround this.
Wait. Why the fact a device is enslaved has to affect the udev in any way? If it does, smells like a bug in udev. > >Secondly, the select queue needs to call queue selection in VF. >The bonding/teaming logic doesn't work well for UDP flows. >Commit b3bf5666a510 ("hv_netvsc: defer queue selection to VF") >fixed this performance problem. > >Lastly, more indirection is bad in current climate. > >I am not completely adverse to this but it needs to be fast, simple >and completely transparent. _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization