On 5/22/22 21:07, Christophe JAILLET wrote:
Now that a private buffer is allocated (see commit in the Fixes tag), it must be released in all error handling paths. Add the missing goto to avoid a leak in the error handling path. Fixes: 42e6ac99e417 ("virtio-crypto: use private buffer for control request") Signed-off-by: Christophe JAILLET <christophe.jail...@wanadoo.fr> --- drivers/crypto/virtio/virtio_crypto_skcipher_algs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/virtio/virtio_crypto_skcipher_algs.c b/drivers/crypto/virtio/virtio_crypto_skcipher_algs.c index e553ccadbcbc..e5876286828b 100644 --- a/drivers/crypto/virtio/virtio_crypto_skcipher_algs.c +++ b/drivers/crypto/virtio/virtio_crypto_skcipher_algs.c @@ -239,7 +239,8 @@ static int virtio_crypto_alg_skcipher_close_session( pr_err("virtio_crypto: Close session failed status: %u, session_id: 0x%llx\n", ctrl_status->status, destroy_session->session_id);- return -EINVAL;+ err = -EINVAL; + goto out; }err = 0;
This looks good to me, thanks! Acked-by: zhenwei pi <pizhen...@bytedance.com> -- zhenwei pi _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
