RE: [PATCH] virtio-crypto: Fix an error handling path in virtio_crypto_alg_skcipher_close_session()

[Gonglei (Arei) via Virtualization]

> -----Original Message-----
> From: Christophe JAILLET [mailto:christophe.jail...@wanadoo.fr]
> Sent: Sunday, May 22, 2022 9:07 PM
> To: dan.carpen...@oracle.com; Gonglei (Arei) <arei.gong...@huawei.com>;
> Michael S. Tsirkin <m...@redhat.com>; Jason Wang <jasow...@redhat.com>;
> Herbert Xu <herb...@gondor.apana.org.au>; David S. Miller
> <da...@davemloft.net>; zhenwei pi <pizhen...@bytedance.com>
> Cc: linux-ker...@vger.kernel.org; kernel-janit...@vger.kernel.org; Christophe
> JAILLET <christophe.jail...@wanadoo.fr>;
> virtualization@lists.linux-foundation.org; linux-cry...@vger.kernel.org
> Subject: [PATCH] virtio-crypto: Fix an error handling path in
> virtio_crypto_alg_skcipher_close_session()
> 
> Now that a private buffer is allocated (see commit in the Fixes tag), it must 
> be
> released in all error handling paths.
> 
> Add the missing goto to avoid a leak in the error handling path.
> 
> Fixes: 42e6ac99e417 ("virtio-crypto: use private buffer for control request")
> Signed-off-by: Christophe JAILLET <christophe.jail...@wanadoo.fr>
> ---
>  drivers/crypto/virtio/virtio_crypto_skcipher_algs.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 

Reviewed-by: Gonglei <arei.gong...@huawei.com>

Regards,
-Gonglei

> diff --git a/drivers/crypto/virtio/virtio_crypto_skcipher_algs.c
> b/drivers/crypto/virtio/virtio_crypto_skcipher_algs.c
> index e553ccadbcbc..e5876286828b 100644
> --- a/drivers/crypto/virtio/virtio_crypto_skcipher_algs.c
> +++ b/drivers/crypto/virtio/virtio_crypto_skcipher_algs.c
> @@ -239,7 +239,8 @@ static int virtio_crypto_alg_skcipher_close_session(
>               pr_err("virtio_crypto: Close session failed status: %u, 
> session_id:
> 0x%llx\n",
>                       ctrl_status->status, destroy_session->session_id);
> 
> -             return -EINVAL;
> +             err = -EINVAL;
> +             goto out;
>       }
> 
>       err = 0;
> --
> 2.34.1

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization