On Wed, Jul 15, 2026 at 04:09:06PM +0800, Weimin Xiong wrote: > From: xiongweimin <[email protected]> > > Replace FIXME comments with clearer Note comments documenting > that BIDI (bidirectional) operations are not yet supported. > > Signed-off-by: Weimin Xiong <[email protected]> > Co-authored-by: Cursor <[email protected]> > --- > drivers/vhost/scsi.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c > index 9a1253b9d..81e905c4c 100644 > --- a/drivers/vhost/scsi.c > +++ b/drivers/vhost/scsi.c > @@ -1047,7 +1047,7 @@ static void vhost_scsi_target_queue_cmd(struct > vhost_scsi_nexus *nexus, > struct se_cmd *se_cmd = &cmd->tvc_se_cmd; > struct scatterlist *sg_ptr, *sg_prot_ptr = NULL; > > - /* FIXME: BIDI operation */ > + /* Note: BIDI (bidirectional) operations are not yet supported */ > if (cmd->tvc_sgl_count) { > sg_ptr = cmd->table.sgl; > > @@ -1168,7 +1168,7 @@ vhost_scsi_get_desc(struct vhost_scsi *vs, struct > vhost_virtqueue *vq, > > /* > * Get the size of request and response buffers. > - * FIXME: Not correct for BIDI operation > + * Note: Size calculation is not correct for BIDI operations. > */ > vc->out_size = iov_length(vq->iov, vc->out); > vc->in_size = iov_length(&vq->iov[vc->out], vc->in); > -- > 2.43.0 >
Hey Weimin, This series is probably going to be ignored. Comment-only changes are almost never merged, and the code changes here don't look like genuine bugs. In the case that there are some real bugs, I'd recommend to setup a system and trigger a bug, and provide a reproducer. Best, Bobby
