Jean-Baptiste Kempf pushed to branch 3.0.x at VideoLAN / VLC
Commits:
18ab3e56 by Khalid Masum at 2025-12-02T23:25:31+01:00
libass: fix possible nullptr deref
vlc_stream_MemoryNew may return NULL. Which could be dereferenced
by vlc_stream_ReadLine calls in OldEngineClunkyRollInfoPatch.
Fixes: #29363 (Coverity 1666281)
(cherry picked from commit 0b7831694bbee4e001aede459f76d1d0da74f2e4)
Signed-off-by: Jean-Baptiste Kempf <[email protected]>
- - - - -
1 changed file:
- modules/codec/libass.c
Changes:
=====================================
modules/codec/libass.c
=====================================
@@ -775,6 +775,9 @@ static void OldEngineClunkyRollInfoPatch( decoder_t *p_dec,
ASS_Track *p_track )
stream_t *p_memstream = vlc_stream_MemoryNew( p_dec, p_dec->fmt_in.p_extra,
p_dec->fmt_in.i_extra, true
);
+ if (unlikely(!p_memstream))
+ return;
+
char *s = vlc_stream_ReadLine( p_memstream );
unsigned playres[2] = {0, 0};
bool b_hotfix = false;
View it on GitLab:
https://code.videolan.org/videolan/vlc/-/commit/18ab3e56f0d02564d0de6110c4f16395f7d7771f
--
View it on GitLab:
https://code.videolan.org/videolan/vlc/-/commit/18ab3e56f0d02564d0de6110c4f16395f7d7771f
You're receiving this email because of your account on code.videolan.org.
VideoLAN code repository instance_______________________________________________
vlc-commits mailing list
[email protected]
https://mailman.videolan.org/listinfo/vlc-commits
