Jean-Baptiste Kempf pushed to branch 3.0.x at VideoLAN / VLC
Commits:
84125cb5 by Steve Lhomme at 2025-12-03T00:00:10+01:00
taglib: use non-deprecated File constructor
The deprecated info was added in 1.5 [^1]. But the constructor was added in 2.0
[^2].
The parameters are the same, in a different order and the factory is optional.
Fixes #29391
[^1]:
https://github.com/taglib/taglib/commit/4879eb8e6e6bf46b89a4a67f62cada82478bade5
[^2]:
https://github.com/taglib/taglib/commit/56fa36934e5633122fcbf305d98f2111caeb5315
(cherry picked from commit 98f4a840ec6a8be5d2db735598724652dcdecb6b)
Signed-off-by: Jean-Baptiste Kempf <[email protected]>
- - - - -
1 changed file:
- modules/meta_engine/taglib.cpp
Changes:
=====================================
modules/meta_engine/taglib.cpp
=====================================
@@ -173,7 +173,11 @@ File*
VLCTagLib::ExtResolver<T>::createFileFromStream(IOStream* s, bool, AudioPr
std::string fext = filename.substr(namesize - ext.length(),
ext.length());
std::transform(fext.begin(), fext.end(), fext.begin(), ::toupper);
if(fext == ext)
+#if TAGLIB_VERSION >= VERSION_INT(2, 0, 0)
+ return new T(s, false, AudioProperties::Fast,
ID3v2::FrameFactory::instance());
+#else
return new T(s, ID3v2::FrameFactory::instance(), false,
AudioProperties::Fast);
+#endif
}
return nullptr;
View it on GitLab:
https://code.videolan.org/videolan/vlc/-/commit/84125cb58eb716dd6c79cdb478051bde0cde6c46
--
View it on GitLab:
https://code.videolan.org/videolan/vlc/-/commit/84125cb58eb716dd6c79cdb478051bde0cde6c46
You're receiving this email because of your account on code.videolan.org.
VideoLAN code repository instance_______________________________________________
vlc-commits mailing list
[email protected]
https://mailman.videolan.org/listinfo/vlc-commits
