On Mon, Aug 18, 2003 at 03:57:12PM -0400, [EMAIL PROTECTED] wrote:
> The Manifest.t test is careful enough to maniadd a lower
> case lc('META.yml') for VMS's benefit but then turns around and
> carried out the check of a redundant maniadd() call
> with the mixed case version of the file name.
> The enclosed patch has been tested on VMS 7.3-1
> and on Linux 2.4.18-14smp:

There's really no reason it has to use META.yml.  I was just being
lazy and reusing the existing MANIFEST.

Try this simpler patch instead.

--- Manifest.t  8 Aug 2003 20:51:56 -0000       1.17
+++ Manifest.t  19 Aug 2003 00:05:53 -0000
@@ -200,12 +200,15 @@
              );
 is_deeply( $files, \%expect, 'maniadd() vs MANIFEST without trailing newline');
 
+add_file('MANIFEST'   => 'Makefile.PL');
+maniadd({ foo => 'bar' });
+
 SKIP: {
     chmod( 0400, 'MANIFEST' );
     skip "Can't make MANIFEST read-only", 2 if -w 'MANIFEST';
 
     eval {
-        maniadd({ 'META.yml' => 'hock' });
+        maniadd({ 'foo' => 'bar' });
     };
     is( $@, '',  "maniadd() won't open MANIFEST if it doesn't need to" );
 

-- 
Michael G Schwern        [EMAIL PROTECTED]  http://www.pobox.com/~schwern/
"Let's face it," said bearded Rusty Simmons, opening a can after the
race.  "This is a good excuse to drink some beer."  At 10:30 in the
morning?  "Well, it's past noon in Dublin," said teammate Mike
[Joseph] Schwern.  "It's our duty."
    -- "Sure, and It's a Great Day for Irish Runners" 
       Newsday, Sunday, March 20, 1988

Reply via email to