Craig Berry wrote in reply to Michael G. Schwern:
>>There's really no reason it has to use META.yml. I was just being
>>lazy and reusing the existing MANIFEST.
>>
>>Try this simpler patch instead.
>
>Schwern's simpler patch works for me and gets all
>tests passing for 20760 on OpenVMS Alpha 7.2-1.
I am sorry to report that Michael's patch as is
against [EMAIL PROTECTED] does not work for me
since it causes test #34 to fail. Michael's
patch approach is better and simpler, but for me,
missing the change to the %expect hash caused
the failure of test 34. Here is a revised patch
that incorporates Michael's excellent simplicity
idea and also adds 'foo' => 'bar' to the %expect
hash needed to get the test to pass on VMS V7.3-1
ODS-2 volume structure, (and also on linux
2.4.18-14smp for x86). This diff is taken
against an otherwise unpatched [EMAIL PROTECTED]
changelist:
diff -ru perl_20760/lib/ExtUtils/t/Manifest.t perl/lib/ExtUtils/t/Manifest.t
--- perl_20760/lib/ExtUtils/t/Manifest.t 2003-08-18 12:48:39.000000000 -0400
+++ perl/lib/ExtUtils/t/Manifest.t 2003-08-19 10:09:48.000000000 -0400
@@ -191,12 +191,12 @@
is( $files->{foobar}, '', ' preserved old entries' );
add_file('MANIFEST' => 'Makefile.PL');
-maniadd({ 'META.yml' => 'Module meta-data (added by MakeMaker)' });
+maniadd({ foo => 'bar' });
$files = maniread;
# VMS downcases the MANIFEST. We normalize it here to match.
%$files = map { (lc $_ => $files->{$_}) } keys %$files;
my %expect = ( 'makefile.pl' => '',
- 'meta.yml' => 'Module meta-data (added by MakeMaker)'
+ 'foo' => 'bar'
);
is_deeply( $files, \%expect, 'maniadd() vs MANIFEST without trailing newline');
@@ -205,7 +205,7 @@
skip "Can't make MANIFEST read-only", 2 if -w 'MANIFEST';
eval {
- maniadd({ 'META.yml' => 'hock' });
+ maniadd({ 'foo' => 'bar' });
};
is( $@, '', "maniadd() won't open MANIFEST if it doesn't need to" );
End of Patch.
Here also as an attachment:
(See attached file: manifest_schwern2.patch)
I hope that helps. Please let me know if Schwern's
patch was already applied to perl in which case I can
reformulate the %expect tweak against a later kit.
Peter Prymmer
manifest_schwern2.patch
Description: Binary data
