On Sun, Feb 05, 2006 at 06:10:58PM -0600, Craig A. Berry wrote:
> At 3:39 PM -0800 2/5/06, Yitzchak Scott-Thoennes wrote:
>
> >Any progress on this front? Given that this is just for purposes of
> >running tests, maybe here the hash keys should always be lowercased?
> >
> >The previous patch to add Module::Build no longer applies cleanly;
> >
> >http://zipcon.net/~sthoenna/mbaddfull270701.patch
> >
> >is updated to match bleadperl and what's currently in cvs for MB.
>
> I'll try to look at that again soon -- too many projects in progress
> at once. I did some hacking with Tie:CPHash from CPAN and got a bit
> farther. A still not fully working diff of DistGen.pm is at the end
> of this message.
> --- DistGen.pm;2 Thu Jan 26 18:48:29 2006
> +++ DistGen.pm Sun Jan 29 15:58:55 2006
> +use Tie::CPHash;
>
> sub new {
> my $package = shift;
> @@ -29,6 +30,10 @@
> );
> my $self = bless( \%data, $package );
>
> + tie %{$self->{filedata}}, 'Tie::CPHash';
> +
> + tie %{$self->{pending}{change}}, 'Tie::CPHash';
Ken, do you have any problem with bundling Tie::CPHash in
Module::Build under t/bundled? The .pm file is just 5k.
Alternatively, it could be a build prerequisite, but I'm guessing
you'd rather not do that.
Rafael, what do you think about adding it to the core along with
Module-Build? If the Module::Build tests need it, it would need to be
included in the perl source, but wouldn't necessarily have to get
installed. But if Craig or someone else ends up modifying
ExtUtils::Manifest::manifind to rely on it at some point in the not
too distant future, it might make sense just to add it already.
A short review: the module looks pretty clean and simple; it does one
thing and does it with no frills. It could stand to have a SCALAR
method added, but other than that the 8 year old code looks great.
