At 10:59 AM +0200 4/21/07, Rafael Garcia-Suarez wrote: >On 20/04/07, Craig A. Berry <[EMAIL PROTECTED]> wrote: >>I don't want to clog up the process of integrating modules, but is it >>particularly hard to pull the private t/ and lib/ directories up >>under the top-level t/ and lib/ directories? Don't a lot of modules >>already do that? >> >> >>% perl Porting/check83.pl | grep levels >>more than eight levels deep: >>ext/IO/Compress/Base/lib/IO/Compress/Base/Common.pm >>more than eight levels deep: >>ext/IO/Compress/Zlib/lib/IO/Compress/Adapter/Deflate.pm >>more than eight levels deep: >>ext/IO/Compress/Zlib/lib/IO/Compress/Adapter/Identity.pm >>more than eight levels deep: >>ext/IO/Compress/Zlib/lib/IO/Compress/Gzip/Constants.pm >>more than eight levels deep: >>ext/IO/Compress/Zlib/lib/IO/Compress/Zip/Constants.pm >>more than eight levels deep: >>ext/IO/Compress/Zlib/lib/IO/Compress/Zlib/Constants.pm >>more than eight levels deep: >>ext/IO/Compress/Zlib/lib/IO/Compress/Zlib/Extra.pm >>more than eight levels deep: >>ext/IO/Compress/Zlib/lib/IO/Uncompress/Adapter/Identity.pm >>more than eight levels deep: >>ext/IO/Compress/Zlib/lib/IO/Uncompress/Adapter/Inflate.pm > >That's code, to be built and installed; I don't see a nice solution, >here's a proposal: > >1. move under /lib/ the modules that don't require XS modules
Yes, but it looks like everything under ext/IO/Compress/Zlib has Compress::Raw::Zlib as a prerequisite, so there aren't any of those in the list and I shouldn't have suggested it. >2. move under their own /ext/ subdir the modules that require other XS >modules (need to change the compilation process.) It looks like we might just make it by renaming ext/IO/Compress/Base to ext/IO_Compress_Base and ext/IO/Compress/Zlib to ext/IO_Compress_Zlib. This would be similar to what's been done in the past to, for example SDBM_File. It might even ease future CPAN integration because these modules currently live there under src/PMQS/IO-Compress-Base-2.004/ and src/PMQS/IO-Compress-Zlib-2.004/. In other words, the extra directory levels appear to have been created for core integration and are not preserving something that exists elsewhere. I'm cc'ing Paul to make sure he doesn't have a better suggestion. >>more than eight levels deep: >>lib/CPANPLUS/t/dummy-CPAN/authors/id/E/EU/EUNOXS/CHECKSUMS >>more than eight levels deep: >>lib/CPANPLUS/t/dummy-CPAN/authors/id/E/EU/EUXS/CHECKSUMS >>more than eight levels deep: >>lib/CPANPLUS/t/dummy-CPAN/authors/id/M/MB/MBNOXS/CHECKSUMS >>more than eight levels deep: >>lib/CPANPLUS/t/dummy-CPAN/authors/id/M/MB/MBXS/CHECKSUMS >>more than eight levels deep: >>lib/CPANPLUS/t/dummy-localmirror/authors/id/E/EU/EUNOXS/CHECKSUMS >>more than eight levels deep: >>lib/CPANPLUS/t/dummy-localmirror/authors/id/E/EU/EUXS/CHECKSUMS >>more than eight levels deep: >>lib/CPANPLUS/t/dummy-localmirror/authors/id/M/MB/MBNOXS/CHECKSUMS >>more than eight levels deep: >>lib/CPANPLUS/t/dummy-localmirror/authors/id/M/MB/MBXS/CHECKSUMS >>more than eight levels deep: >>lib/Module/Load/Conditional/t/to_load/Must/Be/Loaded.pm >>more than eight levels deep: >>lib/Module/Pluggable/t/acme/Acme/MyTest/Plugin/Foo.pm >>more than eight levels deep: >>lib/Module/Pluggable/t/lib/Acme/MyTest/Plugin/Foo.pm >>more than eight levels deep: >>lib/Module/Pluggable/t/lib/ExtTest/Plugin/Quux/Foo.plugin >>more than eight levels deep: >>lib/Module/Pluggable/t/lib/MyOtherTest/Plugin/Quux/Foo.pm >>more than eight levels deep: >>lib/Module/Pluggable/t/lib/MyTest/Extend/Plugin/Bar.pm >>more than eight levels deep: >>lib/Module/Pluggable/t/lib/MyTest/Plugin/Quux/Foo.pm >>more than eight levels deep: lib/Module/Pluggable/t/lib/TA/C/A/I.pm > >probably better to move all of those under t/lib (like Test::More does) Makes sense to me. I need to read up on the p4 commands to move things as I've never done that before. -- ________________________________________ Craig A. Berry mailto:[EMAIL PROTECTED] "... getting out of a sonnet is much more difficult than getting in." Brad Leithauser
