At 12:21 AM -0500 8/31/07, John E. Malmberg wrote:
>In lib/CPANPLUS/Internals/Extract.pm, VMS needs to use catfile to deal
>with combining path components that could include a file name component.
>
>If C<catfile> will work for all platforms, then the test for VMS can be
>removed.

A straight replacement of catdir with catfile worked on both VMS and
Mac OS X, so that's what I checked it into blead as #31776.

>-John
>[EMAIL PROTECTED]
>Personal Opinion Only.
>
>
>--- /rsync_root/perl/lib/CPANPLUS/Internals/Extract.pm Tue Apr 10 02:43:20 2007
>+++ lib/CPANPLUS/Internals/Extract.pm  Thu Aug 30 00:08:54 2007
>@@ -183,7 +183,14 @@
>     #            @{$ae->files};
>    
>     for my $file ( @{$ae->files} ) {
>-        my $path = File::Spec->rel2abs( File::Spec->catdir($to, $file) );
>+        my $rel_path;
>+        if ($^O eq 'VMS') {
>+            # VMS needs catfile to deal with paths that may include a file
>+            $rel_path = File::Spec->catfile($to, $file);
>+        } else {
>+            $rel_path = File::Spec->catdir($to, $file);
>+        }
>+        my $path = File::Spec->rel2abs( $rel_path );
>    
>         $self->_mode_plus_w( file => $path );
>     }


-- 
________________________________________
Craig A. Berry
mailto:[EMAIL PROTECTED]

"... getting out of a sonnet is much more
 difficult than getting in."
                 Brad Leithauser

Reply via email to