On Sep 28, 2007, at 8:55 AM, John E. Malmberg wrote:

Additional changes:

In Base.pm, created a subroutine to return the regex either as case insensitive or case sensitive based on the setting for File::Spec::case_tolerant.

Note in the existing code, one place assumes that the File::Spec::case_tolerant routine exists, and another tests to see if it exists.

Converted were needed the qr{xxxx} to file_qr('xxxx')

[...]

I missed runthrough.t in my last assessment.

This patch also fixes runthrough.t to pass all tests on VMS.

Modifying the expected dist_dir to meet what VMS expects it to be in, handling both ODS-2 and ODS-5 cases.

Skipping the rewritten shebang test, since the shebang is not rewritten on VMS.


Thanks, John.

I assume that in process_support_files() you meant file_qr('\.c(pp)? $') and not qr('\.c(pp)?$').

The M::B::Platform::VMS hunk didn't apply cleanly against the svn repo, something about a manpage separator. There seems to be no such code to what's getting patched, do you know what's going on there?

Also, the t/install.t patch caused some new failures so I haven't applied that yet.

 -Ken


Reply via email to