Wouldn’t it be better to have separate projects for each plugin (or maybe 
groups of them) and thereby have maintainers automatically become committers 
within their respective projects? As far as I can see this diminishes load on 
VPP committers and gives the required ‘power' to the interested parties. 

Just my 0.02$

Florin

> On Dec 21, 2016, at 10:25 AM, Damjan Marion <[email protected]> wrote:
> 
>> 
>> On 21 Dec 2016, at 18:49, Kinsella, Ray <[email protected]> wrote:
>> 
>> 
>>> If somebody submits plugin change + 3 lines of new
>>> code in critical ip4 path, I will greatly benefit from +1 received from
>>> plugin maintainer and i will focus on this 3 lines.
>>> If I don’t have +1 from plugin maintainer, i will just left whole diff
>>> in the gerrit, simply because i don't have a clue about that plugin.
>> 
>> But really, the committer will have nothing to add about the plugin in this 
>> case.
>> 
>> A more efficient process would be to let an IPv4 committer review and commit 
>> the IPv4 change, with the Plugin committer separately doing likewise.
>> 
>> Many open source project require that patches be made separately for 
>> component.
> 
> Yes, and hire one guy to bitch with people who are not following that rule...
> _______________________________________________
> vpp-dev mailing list
> [email protected] <mailto:[email protected]>
> https://lists.fd.io/mailman/listinfo/vpp-dev 
> <https://lists.fd.io/mailman/listinfo/vpp-dev>
_______________________________________________
vpp-dev mailing list
[email protected]
https://lists.fd.io/mailman/listinfo/vpp-dev

Reply via email to