On 05/08/2017 10:11 AM, Damjan Marion (damarion) wrote:

On 3 May 2017, at 17:20, Jon Loeliger <j...@netgate.com <mailto:j...@netgate.com>> wrote:

Hey VPP Builders,

Do you ever use "cd build-root; make distclean"?
Does it look sort of like this:


jdl $ cd build-root/
jdl $ make distclean
rm -rf /home/jdl/workspace/vpp/build-root/build-*/
rm -rf /home/jdl/workspace/vpp/build-root/build-tool-*
rm -rf /home/jdl/workspace/vpp/build-root/install-*
rm -rf /home/jdl/workspace/vpp/build-root/images-*
rm -rf /home/jdl/workspace/vpp/build-root/tools
rm -rf /home/jdl/workspace/vpp/build-root/*.deb
rm -rf /home/jdl/workspace/vpp/build-root/*.rpm
rm -rf /home/jdl/workspace/vpp/build-root/*.changes
rm -rf /home/jdl/workspace/vpp/build-root/python
if [ -e /usr/bin/dh ];then (cd /home/jdl/workspace/vpp/build-root/deb/;debian/rules clean); fi
rm -f /home/jdl/workspace/vpp/build-root/deb/debian/*.install
rm -f /home/jdl/workspace/vpp/build-root/deb/debian/changelog

Remember back in

commit c06eeb0e3c9c1a9fa8f913e2d785b03220bfdabd
Author: Damjan Marion <damar...@cisco.com <mailto:damar...@cisco.com>>
Date:   Tue Apr 18 15:26:39 2017 +0200

Fix "make dist" to include version number, docouple it from rpm packaging

    Change-Id: If2f9976d668089026c97b897cf449bff09050631
Signed-off-by: Damjan Marion <damar...@cisco.com <mailto:damar...@cisco.com>>

when we moved the RPM building pieces out of build-root/rpm and
placed them under extras/rpm instead?

Should we have also modified the distclean make target to rm the rpms
out of extras/rpm too?  Or was that an intentional change as well?

Makes sense to do that from top level makefile, i.e. run "git clean -fdX” but
I would prefer that build-root/Makefile only takes care for build-root/.
+1


_______________________________________________
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

--
*Thomas F Herbert*
Fast Data Planes
Office of Technology
*Red Hat*
_______________________________________________
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Reply via email to