Please, take a look at my patch just pushed...https://gerrit.fd.io/r/#/c/14716/ On Fri, 2018-09-07 at 10:44 +0200, Damjan Marion wrote: > Folks, > I'm going to revert this change, as it breaks compilation on non-cavium > systems. > That patch wrongly changes default cacheline size for all AArch64 platforms to > 128 bytes... > > -- > Damjan > > > > > On 6 Sep 2018, at 15:52, Nitin Saxena <nitin.sax...@cavium.com> wrote: > > > > > > > > > > > > Thanks Marco, Damjan. Adding cpu id fixes the compilationPushed the patch: > > https://gerrit.fd.io/r/#/c/14701/Thanks, > > > > Nitin > > > > > > > > > > On Thursday 06 September 2018 07:06 PM, > > Damjan Marion wrote: > > > > > > > > > External Email > > > > > > > > > > > > > > > Dear Nitin, > > > > > > > > > > > > Yes, it is missing. I took care only for platforms I have > > > access to... > > > > > > > > > > > > — > > > Damjan > > > > > > > > > > > > On 6 Sep 2018, at 14:04, Nitin Saxena <nitin.sax...@cavium.com > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > Hi Damjan,cmake is making Cavium's OCTEONTx build failure. > > > > Following is the failure > > > > log================================================================ > > > > > > > > In function ‘dpdk_init’: > > > > > > > > /home/nsaxena/vpp/src/plugins/dpdk/device/init.c:1802:3: > > > > error: static assertion failed: "DPDK RTE CACHE LINE > > > > SIZE does not match with > > > > 1<<CLIB_LOG2_CACHE_LINE_BYTES" > > > > > > > > STATIC_ASSERT (RTE_CACHE_LINE_SIZE == 1 << > > > > CLIB_LOG2_CACHE_LINE_BYTES,============================= > > > > ==================================I am failing to see translation of > > > > Autoconf changes > > > > from commit id: 473f46135c3fd77dad5614215cc279b1164e9a74 > > > > to CMake.Thanks,Nitin > > > > > > > > > > > > On Sunday 02 September 2018 > > > > 06:18 PM, Damjan Marion via Lists.Fd.Io wrote: > > > > > > > > > > > > > > > > > External Email > > > > > > > > > > > > > > > > > > > > > > > > > Dear all, > > > > > > > > > > > > > > > > > > > > We just switched from autotools to cmake > > > > > and retired all autotools related files in src/. > > > > > > > > > > > > > > > > > > > > All verify jobs are ok, and we also > > > > > tried it on 3 different x86 and 2 different ARM > > > > > Aarch64 machines. > > > > > > > > > > > > > > > > > > > > Due to blast radius, i will not be > > > > > surprised that some small issues pop out, but i > > > > > don't expect anything hard to fix. > > > > > > > > > > > > > > > > > > > > Let us know if you hit something... > > > > > > > > > > > > > > > > > > > > PS As a part of this change, CentOS 7 > > > > > build are now using devtoolset-7, so they are > > > > > compiled with gcc-7, which also means images have > > > > > support for Skylake Servers (AVX512). > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > > > Damjan > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=-Links: You receive all messages > > > > > sent to this group. > > > > > View/Reply Online (#10337): > > > > > https://lists.fd.io/g/vpp-dev/message/10337Mute This Topic: > > > > > https://lists.fd.io/mt/25155374/675748Group Owner: vpp- > > > > > dev+ow...@lists.fd.ioUnsubscribe: https://lists.fd.io/g/vpp-dev/unsubb > > > > > [nsax...@caviumnetworks.com]-=-=-=-=-=-=-=-=-=-=-=- > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- > > > > > > > > Links: You receive all messages sent to this group. > > > > > > > > > > > > > > > > View/Reply Online (#10407): > > > > https://lists.fd.io/g/vpp-dev/message/10407 > > > > > > > > Mute This Topic: https://lists.fd.io/mt/25155374/675642 > > > > > > > > Group Owner: vpp-dev+ow...@lists.fd.io > > > > > > > > Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub > > > > [dmar...@me.com] > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- Marco V
SUSE LINUX GmbH | GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Maxfeldstr. 5, D-90409, Nürnberg
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#10426): https://lists.fd.io/g/vpp-dev/message/10426 Mute This Topic: https://lists.fd.io/mt/25155374/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
