Since qsort.c from vppinfra has the buffer overflow issue, shall we delete this file to avoid causing more confusion in the future? -John
From: vpp-dev@lists.fd.io <vpp-dev@lists.fd.io> On Behalf Of Damjan Marion via Lists.Fd.Io Sent: Friday, September 07, 2018 4:30 AM To: Damjan Marion <dmar...@me.com> Cc: vpp-dev@lists.fd.io Subject: Re: [vpp-dev] cmake is on I just did it: https://gerrit.fd.io/r/#/c/14711/ -- Damjan On 7 Sep 2018, at 09:25, Damjan Marion via Lists.Fd.Io <dmarion=me....@lists.fd.io<mailto:dmarion=me....@lists.fd.io>> wrote: Dear Kingwei, That should be easy to fix. Can you just remove it and submit patch, so i can merge it? Thanks, -- Damjan On 7 Sep 2018, at 02:39, Kingwel Xie <kingwel....@ericsson.com<mailto:kingwel....@ericsson.com>> wrote: Hi Damijan, Thanks for the great job done. It is now much faster. We noticed a difference between using cmake and automake in the latest code: Vppinfra/qsort.c is included in vppinfra/CMakefile.txt but not in vppinfra.am, which creates a situation that cmake image would be linked to the qsort.c but automake linked to glibc. The reason why we noticed is there is a buffer overrun bug in qsort.c that causes cli crashed occasionally. Please comment how to fix. Personally I’d like to remove qsort.c, like before. Regards, Kingwel From: vpp-dev@lists.fd.io<mailto:vpp-dev@lists.fd.io> <vpp-dev@lists.fd.io<mailto:vpp-dev@lists.fd.io>> On Behalf Of Damjan Marion via Lists.Fd.Io Sent: Sunday, September 02, 2018 8:48 PM To: vpp-dev <vpp-dev@lists.fd.io<mailto:vpp-dev@lists.fd.io>> Cc: vpp-dev@lists.fd.io<mailto:vpp-dev@lists.fd.io> Subject: [vpp-dev] cmake is on Dear all, We just switched from autotools to cmake and retired all autotools related files in src/. All verify jobs are ok, and we also tried it on 3 different x86 and 2 different ARM Aarch64 machines. Due to blast radius, i will not be surprised that some small issues pop out, but i don't expect anything hard to fix. Let us know if you hit something... PS As a part of this change, CentOS 7 build are now using devtoolset-7, so they are compiled with gcc-7, which also means images have support for Skylake Servers (AVX512). -- Damjan -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#10420): https://lists.fd.io/g/vpp-dev/message/10420 Mute This Topic: https://lists.fd.io/mt/25155374/675642 Group Owner: vpp-dev+ow...@lists.fd.io<mailto:vpp-dev+ow...@lists.fd.io> Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [dmar...@me.com<mailto:dmar...@me.com>] -=-=-=-=-=-=-=-=-=-=-=- -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#10421): https://lists.fd.io/g/vpp-dev/message/10421 Mute This Topic: https://lists.fd.io/mt/25155374/675642 Group Owner: vpp-dev+ow...@lists.fd.io<mailto:vpp-dev+ow...@lists.fd.io> Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [dmar...@me.com<mailto:dmar...@me.com>] -=-=-=-=-=-=-=-=-=-=-=-
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#10433): https://lists.fd.io/g/vpp-dev/message/10433 Mute This Topic: https://lists.fd.io/mt/25155374/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
