On Thu, 20 Sep 2018 18:56:28 +0000 "Steven Luong (sluong)" <[email protected]> wrote:
> Stephen, > > Fix for vhost > https://gerrit.fd.io/r/14920 > > I'll take care of vmxnet3 later. > > Steven > > On 9/20/18, 10:57 AM, "[email protected] on behalf of Stephen Hemminger" > <[email protected] on behalf of [email protected]> wrote: > > <meta rant> > Why is there not a simple link on FD.io developer web page to report bugs. > Reporting bugs page talks about the data BUT DOESN'T GIVE THE PROCESS. > > If you are using JIRA why not vpp-bugs mail alias? > </meta rant> > > > I tried creating a virtio user device and noticed that the device name > displayed is garbage: > DBGvpp# create vhost-user socket /var/run/vpp/sock1.sock server > VirtualEthernet0/0/0 > DBGvpp# show vhost-user > Virtio vhost-user interfaces > Global: > coalesce frames 32 time 1e-3 > number of rx virtqueues in interrupt mode: 0 > Interface: VirtualEthernet0/0/0�?x�D (ifindex 3) > ^^^^^^ > > Looking at source, vmxnet3 has same bug. > > > Looks like a bug related to string handling. > Somewhat disgruntled that VPP had to reinvent strings in C. > > Perhaps the format() function could change to use a compatiable syntax with GCC like the Linux printk. For the special formats like %U and %V, change them to be modifiers to pointer format: %U -> %pU %V -> %pV Then it is possible to add printf format attribute to format() function signature and catch misuse of string/pointer at compile time. Yes it would be a global change to VPP. Not sure about what API guarantees are made to out of tree plugins.
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#10602): https://lists.fd.io/g/vpp-dev/message/10602 Mute This Topic: https://lists.fd.io/mt/25822425/21656 Group Owner: [email protected] Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
