Burt, Just an fyi and a comment…
fyi on the build containers we install cmake (this predated cmakeY being in the Makefile) cmake version 2.8.12.2 cmake3 is installed as part of install dep cmake3 version 3.12.2 My build will fail (centos) without cmake3 CMake Error at CMakeLists.txt:14 (cmake_minimum_required): CMake 3.5 or higher is required. You are running version 2.8.12.2 on my centos container I can get a good build without cmake being installed at all..(only cmake3) Also (because Ive fallen into this hole before) your dnf change wont work because it requires dnf.. If you really want to use dnf you’ll need to install it with yum (or some other way) first then switch over to all dnf based installs. Ed On Nov 24, 2018, at 2:42 PM, Burt Silverman <bur...@gmail.com<mailto:bur...@gmail.com>> wrote: I agree re cmake3, it looks like the correct package is cmake, not cmake3. Maybe something like this is needed (for the Fedora case) since dnf has been around a long time now. diff --git a/Makefile b/Makefile index e0c710fd..3c8d7c31 100644 --- a/Makefile +++ b/Makefile @@ -82,13 +82,13 @@ else DEB_DEPENDS += libssl-dev endif -RPM_DEPENDS = redhat-lsb glibc-static java-1.8.0-openjdk-devel yum-utils +RPM_DEPENDS = redhat-lsb glibc-static java-1.8.0-openjdk-devel dnf RPM_DEPENDS += apr-devel RPM_DEPENDS += numactl-devel RPM_DEPENDS += check check-devel RPM_DEPENDS += boost boost-devel RPM_DEPENDS += selinux-policy selinux-policy-devel -RPM_DEPENDS += cmake3 ninja-build +RPM_DEPENDS += cmake ninja-build ifeq ($(OS_ID)-$(OS_VERSION_ID),fedora-25) RPM_DEPENDS += subunit subunit-devel @@ -300,9 +300,9 @@ ifeq ($(OS_ID),rhel) else ifeq ($(OS_ID),centos) @sudo -E yum install $(CONFIRM) centos-release-scl-rh endif - @sudo -E yum groupinstall $(CONFIRM) $(RPM_DEPENDS_GROUPS) - @sudo -E yum install $(CONFIRM) $(RPM_DEPENDS) - @sudo -E debuginfo-install $(CONFIRM) glibc openssl-libs mbedtls-devel zlib + @sudo -E dnf group install $(CONFIRM) $(RPM_DEPENDS_GROUPS) + @sudo -E dnf install $(CONFIRM) $(RPM_DEPENDS) + @sudo -E dnf debuginfo-install $(CONFIRM) glibc openssl-libs mbedtls-devel zlib openssl-libs else ifeq ($(filter opensuse-tumbleweed,$(OS_ID)),$(OS_ID)) @sudo -E zypper refresh @sudo -E zypper install -y $(RPM_SUSE_DEPENDS) (END) Burt -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#11392): https://lists.fd.io/g/vpp-dev/message/11392 Mute This Topic: https://lists.fd.io/mt/28281426/675649 Group Owner: vpp-dev+ow...@lists.fd.io<mailto:vpp-dev+ow...@lists.fd.io> Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [e...@cisco.com<mailto:e...@cisco.com>] -=-=-=-=-=-=-=-=-=-=-=-
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#11414): https://lists.fd.io/g/vpp-dev/message/11414 Mute This Topic: https://lists.fd.io/mt/28281426/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
