Even more cleaner one will be to add “-“ in front of sudo which tells make to ignore return code :)
Btw i’m responsible for this one, that line was quick fix to address another stupidity of rpm which fails to upgrade package when real file is replaced with symbolic link.... — Damjan > On 2 Jul 2019, at 01:40, Ed Kern via Lists.Fd.Io <ejk=cisco....@lists.fd.io> > wrote: > > > https://gerrit.fd.io/r/#/c/20442/6/build/external/Makefile > > > I was too chicken to suggest it as a clean fix :) > > Ed > > > >> On Jul 1, 2019, at 5:17 PM, Dave Barach (dbarach) <dbar...@cisco.com> wrote: >> >> See https://gerrit.fd.io/r/#/c/20446/ - .../build/external/Makefile needed a >> bit of “|| true” action to avoid falling all over itself if no vpp-ext-deps >> .rpm was installed: >> >> ifneq ($(INSTALLED_RPM_VER),$(RPM_VER)-$(PKG_SUFFIX)) >> @$(MAKE) $(DEV_RPM) >> sudo rpm -e vpp-ext-deps || true >> sudo rpm -Uih --force $(DEV_RPM) >> Definitely fixes the issue in a freshly-built Centos7 VM. >> >> HTH... Dave >> >> From: Ed Kern (ejk) <e...@cisco.com> >> Sent: Monday, July 1, 2019 3:20 PM >> To: Florin Coras <fcoras.li...@gmail.com> >> Cc: vpp-dev <vpp-dev@lists.fd.io>; Dave Barach (dbarach) >> <dbar...@cisco.com>; Thomas F Herbert <therb...@redhat.com> >> Subject: Re: centos jobs failing >> >> adding thomas directly just to cover my centos base… >> >> >> TLDR vpp-ext-deps makefile issues lead to failures resulting in immediate >> job failure…..working on workaround while >> someone comes up with a real fix. >> >> >> >> >> Packagecloud.io retention on master APPEARS to be about a month (unless >> someone hand removed things and didn’t mention it) >> >> vpp-ext-deps-19.08-6.x86_64.rpm/deb was no longer in the repo as of last 12 >> hours or so. >> >> On the next verify run (not finding the prebuilt in package cloud) simply >> built >> vpp-ext-deps*.deb >> and at the end of that job uploaded it back to package cloud and ‘deb-life’ >> builds continued as normal >> >> The scripts that build/install (that are only run when vpp-ext-deps needs >> to be hand built (aka not in package cloud)) >> vpp-ext-deps.rpm >> fail…..and have continued to fail ever since.. >> >> >> Ed >> >> PS.. I’ve done a hand upload of the vpp-ext-deps package for rpm so centos >> builds SHOULD be working again…at least until >> vpp-ext-deps rev’s up (unless we get a fix in place first) >> >> >> >> On Jul 1, 2019, at 11:52 AM, Florin Coras <fcoras.li...@gmail.com> wrote: >> >> It seems the centos package expired in packagecloud. Ed is working on the >> problem. >> >> Florin > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > > View/Reply Online (#13421): https://lists.fd.io/g/vpp-dev/message/13421 > Mute This Topic: https://lists.fd.io/mt/32277567/675642 > Group Owner: vpp-dev+ow...@lists.fd.io > Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [dmar...@me.com] > -=-=-=-=-=-=-=-=-=-=-=-
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#13424): https://lists.fd.io/g/vpp-dev/message/13424 Mute This Topic: https://lists.fd.io/mt/32277567/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
