Hi Burt,

Two separate issues :
  https://gerrit.fd.io/r/c/vpp/+/22597
  https://gerrit.fd.io/r/c/vpp/+/22598

thanks for the report 😊

/neale

From: "Dave Barach (dbarach)" <dbar...@cisco.com>
Date: Monday 7 October 2019 at 21:28
To: "Benoit Ganne (bganne)" <bga...@cisco.com>, Burt Silverman 
<bur...@gmail.com>, vpp-dev <vpp-dev@lists.fd.io>, "Neale Ranns (nranns)" 
<nra...@cisco.com>
Subject: RE: [vpp-dev] test_srmpls.py and test_ip_mcast.py fail under "make 
test-debug"


Dear Ben,



Looping in Neale. The failure is 100% reproducible, due to the highlighted 
ASSERT.



According to gdb, fib_table->ft_total_route_counts is 1 not zero.



HTH... Dave



void

ip6_fib_table_destroy (u32 fib_index)

{

    /*

     * all link local first ...

     */

    fib_prefix_t pfx = {

      .fp_proto = FIB_PROTOCOL_IP6,

      .fp_len = 10,

      .fp_addr = {

          .ip6 = {

                .as_u8 = {

                    [0] = 0xFE,

                    [1] = 0x80,

                },

          },

      }

    };

    fib_table_entry_delete(fib_index,

                           &pfx,

                           FIB_SOURCE_SPECIAL);



    /*

     * ... then the default route.

     */

    pfx.fp_addr.ip6.as_u64[0] = 0;

    pfx.fp_len = 00;

    fib_table_entry_special_remove(fib_index,

                         &pfx,

                         FIB_SOURCE_DEFAULT_ROUTE);



    fib_table_t *fib_table = fib_table_get(fib_index, FIB_PROTOCOL_IP6);

    fib_source_t source;



     /*

     * validate no more routes.

     */

    ASSERT(0 == fib_table->ft_total_route_counts);

    FOR_EACH_FIB_SOURCE(source)

    {

      ASSERT(0 == fib_table->ft_src_route_counts[source]);

    }



    if (~0 != fib_table->ft_table_id)

    {

      hash_unset (ip6_main.fib_index_by_table_id, fib_table->ft_table_id);

    }

    pool_put_index(ip6_main.v6_fibs, fib_table->ft_index);

    pool_put(ip6_main.fibs, fib_table);

}





-----Original Message-----
From: vpp-dev@lists.fd.io <vpp-dev@lists.fd.io> On Behalf Of Benoit Ganne 
(bganne) via Lists.Fd.Io
Sent: Monday, October 7, 2019 12:11 PM
To: Burt Silverman <bur...@gmail.com>; vpp-dev <vpp-dev@lists.fd.io>
Cc: vpp-dev@lists.fd.io
Subject: Re: [vpp-dev] test_srmpls.py and test_ip_mcast.py fail under "make 
test-debug"



> I wonder if anybody knows why 7/10 tests fail for these test cases

> with "make test-debug" but all pass using "make test".



If I remember well, test_ip_mcast fails because of an ASSERT() in ip6 fib 
complaining it is not empty or similar. Obviously this is a bug.

You can check in /tmp/vpp-failed-unittests/*/log.txt to get more information 
about the issue.

We do not run (yet) make test in debug mode as voting jobs (only in release 
mode for now) so we sometime miss some ASSERT()...

If you can open Jira tickets for each one it would be helpful.



ben
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#14141): https://lists.fd.io/g/vpp-dev/message/14141
Mute This Topic: https://lists.fd.io/mt/34429321/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to