Hi Andrew. That used to be the case, not anymore. See: https://gerrit.fd.io/r/c/vpp/+/23521 . Changing just the commit via the UI, triggers everything.
Paul On Wed, Nov 20, 2019 at 6:56 PM Andrew 👽 Yourtchenko <ayour...@gmail.com> wrote: > Does this idea keep in mind a corner case of editing the commit message > over the gerrit UI? > > That operation currently doesn’t trigger the rebuilds... (Though i tend to > use it for a quick edit to recover a checkstyle error, so I would rather > have it trigger the checkstyle :-) > > If these things above do not get worse than today, then +1... > > > --a > > On 20 Nov 2019, at 19:32, Paul Vinciguerra <pvi...@vinciconsulting.com> > wrote: > > How would the group feel about implementing something like [0], so that > changes to the commit message don't trigger rebuilds? > > To enforce the commit message structure, we could skip the jobs and set > verify label after the codestyle checks if no files were changed. > Maybe others don't care, but I don't like wasting cpu cycles/developer's > time, and I weigh that before clarifying a commit message. > > [0] > https://gerrit-review.googlesource.com/Documentation/config-labels.html#label_copyAllScoresIfNoCodeChange > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > > View/Reply Online (#14643): https://lists.fd.io/g/vpp-dev/message/14643 > Mute This Topic: https://lists.fd.io/mt/60969892/675608 > Group Owner: vpp-dev+ow...@lists.fd.io > Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [ayour...@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- > >
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#14650): https://lists.fd.io/g/vpp-dev/message/14650 Mute This Topic: https://lists.fd.io/mt/60969892/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
