> implementing something like [0] +1, but...
> skip the jobs and set verify label after the codestyle checks if no files > were changed ... how do you imagine this being implemented in ci-management? Currently, the other jobs are triggered by checkstyle_success Gerrit comment, but how would the new checkstyle check know when to skip it? I can imagine having two checkstyle jobs (one skippable and commenting, one unskippable and not commenting), but +1 from the latter job would not remove the previous -1 from the former. Vratko. From: vpp-dev@lists.fd.io <vpp-dev@lists.fd.io> On Behalf Of Paul Vinciguerra Sent: Wednesday, November 20, 2019 7:33 PM To: vpp-dev@lists.fd.io Subject: [vpp-dev] Change to Gerrit How would the group feel about implementing something like [0], so that changes to the commit message don't trigger rebuilds? To enforce the commit message structure, we could skip the jobs and set verify label after the codestyle checks if no files were changed. Maybe others don't care, but I don't like wasting cpu cycles/developer's time, and I weigh that before clarifying a commit message. [0] https://gerrit-review.googlesource.com/Documentation/config-labels.html#label_copyAllScoresIfNoCodeChange
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#14660): https://lists.fd.io/g/vpp-dev/message/14660 Mute This Topic: https://lists.fd.io/mt/60969892/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
