Ouch, preparing patch!

Florin

> On Apr 28, 2020, at 12:50 PM, Damjan Marion <dmar...@me.com> wrote:
> 
> 
> Looks like you told compiler that svm_fifo_t will be always cacheline aligned:
> 
>  typedef struct _svm_fifo
>  {
>    CLIB_CACHE_LINE_ALIGN_MARK (shared_first);
> 
> 
> but you increment pointer for something that it is not X*64:
> 
> fmem += hdrs + rounded_data_size;
> 
> So clang caught you cheating :)
> 
> —
> Damjan
> 
> 
> 
>> On 28 Apr 2020, at 21:25, Florin Coras <fcoras.li...@gmail.com 
>> <mailto:fcoras.li...@gmail.com>> wrote:
>> 
>> Hi Damjan, 
>> 
>> Just tried the vcl tests and the debug version works just fine. The release 
>> images crash (at least in the test I’m looking at) doing:
>> 
>> memset (f, 0, sizeof (*f))
>> 
>> From gdb: 
>> 
>> (gdb) x/i $pc
>> => 0x7f15fcd329f4 <fs_try_alloc_fifo_batch+388>:        movaps 
>> %xmm0,0x1f0(%rdi,%rbp,1)
>> (gdb) i r rdi
>> rdi            0x204024780      8657192832
>> (gdb) i r rbp
>> rbp            0x100018 0x100018
>> (gdb) p f
>> $7 = (svm_fifo_t *) 0x204024780 <- the thing being memset
>> 
>> If my math is correct, the right hand operator is 0x1f0 + 0x204024780 + 
>> 0x100018 = 0x204124988. Doesn’t look to be aligned. Could this be the issue? 
>> 
>> Florin
>> 
>>> On Apr 28, 2020, at 7:13 AM, Damjan Marion via lists.fd.io 
>>> <dmarion=me....@lists.fd.io> wrote:
>>> 
>>> 
>>> Folks,
>>> 
>>> As there is bug in gnu assembler which is shipping with ubuntu 18.04 we are 
>>> not able to produce working binaries with avx512 instruction set.
>>> Because of that, I had to change default to avx2. reported bug[1], but it 
>>> is ignored for a year.
>>> 
>>> As alternative[2], I wanted to consider using clang-9 which is shipped with 
>>> ubuntu 18.04 and seems like it is even capable of producing faster binaries 
>>> than gcc.
>>> Unfortunately, "make test" is failing at several places including vxlan, 
>>> ipsec and tcp stack[3].
>>> 
>>> May I ask folks who “own” that code to take a quick look?
>>> 
>>> Thanks,
>>> 
>>> Damjan
>>> 
>>> [1] https://bugs.launchpad.net/ubuntu/cosmic/+source/binutils/+bug/1819961
>>> [2] https://gerrit.fd.io/r/c/vpp/+/26744
>>> [3] https://jenkins.fd.io/job/vpp-verify-master-ubuntu1804/3615/console
>>> 
>>> 
>>> 
>>> 
>> 
>> 

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#16183): https://lists.fd.io/g/vpp-dev/message/16183
Mute This Topic: https://lists.fd.io/mt/73327785/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to