It's in! Thanks a lot! --a
On 7/3/20, Christian Hopps <cho...@chopps.org> wrote: > https://gerrit.fd.io/r/c/vpp/+/27761 > >> On Jun 30, 2020, at 11:23 AM, Andrew Yourtchenko <ayour...@gmail.com> >> wrote: >> >> Hi Christian, >> >> Ok so given it’s a fix, feel free to cherry-pick into 19.08 without the >> API version change, I will merge it. >> >> --a >> >>> On 30 Jun 2020, at 15:52, Ole Troan <otr...@employees.org> wrote: >>> >>> Hi Christian, >>> >>> Changing the patch is fine. >>> The only use of version apart from human indications is for the is api >>> experimental or not by checkstyle-api >>> Cheers >>> Ole >>> >>>> On 30 Jun 2020, at 15:38, Christian Hopps <cho...@chopps.org> wrote: >>>> >>>> I noticed that it was the "patch" version number that changed. Semver >>>> claims the patch number indicates backwards compatible changes -- not >>>> sure how VPP API is using the "patch" number though. So when I resolved >>>> the conflict locally after cherry picking I just changed 3.1.1 to 3.1.2 >>>> to keep the spirit of the change. Reverting the version change upstream >>>> is another solution too, if that helps with the API crc/signature stuff. >>>> I don't fully comprehended the VPP API versioning, so better someone >>>> else makes that call. >>>> >>>> Thanks, >>>> Chris. >>>> >>>>>> On Jun 30, 2020, at 8:04 AM, Dave Barach (dbarach) <dbar...@cisco.com> >>>>>> wrote: >>>>> >>>>> Dear Chris, >>>>> >>>>> In looking at the patch, I have a question: the API version number >>>>> changed despite the fact that the API itself was unchanged. >>>>> >>>>> Should we revert the API version number bump and then cherry-pick to >>>>> 19.08? >>>>> >>>>> Looping in Ole for an opinion... >>>>> >>>>> Thanks... Dave >>>>> >>>>> -----Original Message----- >>>>> From: vpp-dev@lists.fd.io <vpp-dev@lists.fd.io> On Behalf Of Christian >>>>> Hopps >>>>> Sent: Tuesday, June 30, 2020 3:10 AM >>>>> To: vpp-dev <vpp-dev@lists.fd.io> >>>>> Cc: Christian Hopps <cho...@chopps.org> >>>>> Subject: [vpp-dev] name filter fix in 1908 >>>>> >>>>> Could this fix: https://gerrit.fd.io/r/c/vpp/+/23140 >>>>> >>>>> be pulled into stable/1908? >>>>> >>>>> It applies clean after adapting the version number change to be >>>>> compatible with 1908 branch. >>>>> >>>>> Thanks, >>>>> Chris. >>>>> >>>> >>> >> > >
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#16882): https://lists.fd.io/g/vpp-dev/message/16882 Mute This Topic: https://lists.fd.io/mt/75209217/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
