Hoi, I am starting to work on a few APIs and noticed that the vpp_papi module's method find_api_dir promises that it will include VPP_API_DIR first, if specified in the environment. It doesn't actually do that. I wrote a changelist that prepends VPP_API_DIR if it exists. This is backwards compatible / benign because it would not have been useful before this change, and folks will not have it in their environment yet. While I'm here, I thought it would be good to make explicit that the 'dirs' argument is meant to be a list (except it is not initialized or checked, so any invocation without dirs=[] will crash)
See ssh://pimvanp...@gerrit.fd.io:29418/vpp and please review/merge. Ole are you the Python API maintainer ? -- Pim van Pelt <p...@ipng.nl> PBVP1-RIPE - http://www.ipng.nl/
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#22311): https://lists.fd.io/g/vpp-dev/message/22311 Mute This Topic: https://lists.fd.io/mt/95610877/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/leave/1480452/21656/631435203/xyzzy [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
